[webkit-changes] [WebKit/WebKit] 85e2ed: [ Sequoia wk2 ] two accessibility/mac/ pdf tests a...

[Joshua Hoffman]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 85e2ede7862a7216edda0e6eac8e29e97ec01f78
      https://github.com/WebKit/WebKit/commit/85e2ede7862a7216edda0e6eac8e29e97ec01f78
  Author: Joshua Hoffman <jhoffman23 at apple.com>
  Date:   2025-01-14 (Tue, 14 Jan 2025)

  Changed paths:
    M LayoutTests/accessibility/mac/basic-embed-pdf-accessibility-expected.txt
    M LayoutTests/accessibility/mac/basic-embed-pdf-accessibility.html
    M LayoutTests/accessibility/mac/iframe-pdf-expected.txt
    M LayoutTests/accessibility/mac/iframe-pdf.html
    M LayoutTests/platform/mac-wk2/TestExpectations
    M LayoutTests/resources/accessibility-helper.js

  Log Message:
  -----------
  [ Sequoia wk2 ] two accessibility/mac/ pdf tests are a consistent timeout
https://bugs.webkit.org/show_bug.cgi?id=281531
rdar://137996591

Reviewed by Tyler Wilcock.

These PDF tests assumed that the accessibility hierarchy that is vended from PDFKit
does not change. But, between Sonoma and Sequoia, the structure had changed, causing
these tests with pre-defined paths to fail (specifically, when finding the AXPage and
AXStaticText elements).

These are now updated to use a "search" approach to find elements, rather than
a specific path, to avoid hierarchy assumptions and to increase their resilliency
against future changes.

* LayoutTests/accessibility/mac/basic-embed-pdf-accessibility-expected.txt:
* LayoutTests/accessibility/mac/basic-embed-pdf-accessibility.html:
* LayoutTests/accessibility/mac/iframe-pdf-expected.txt:
* LayoutTests/accessibility/mac/iframe-pdf.html:
* LayoutTests/platform/mac-wk2/TestExpectations:
* LayoutTests/resources/accessibility-helper.js:

Canonical link: https://commits.webkit.org/288850@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications