[webkit-changes] [WebKit/WebKit] 724bda: Remove unneeded HeapRef pre-initialization.

Commit Queue noreply at github.com
Tue Jan 14 07:10:22 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 724bda79db73192ea8131ed4a2216a14abe578ef
      https://github.com/WebKit/WebKit/commit/724bda79db73192ea8131ed4a2216a14abe578ef
  Author: Mark Lam <mark.lam at apple.com>
  Date:   2025-01-14 (Tue, 14 Jan 2025)

  Changed paths:
    M Source/JavaScriptCore/runtime/InitializeThreading.cpp
    M Source/WTF/wtf/TZoneMalloc.h
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    R Source/WebCore/platform/WebCoreHeapSupport.cpp
    R Source/WebCore/platform/WebCoreHeapSupport.h
    M Source/WebCore/platform/ios/wak/WebCoreThread.mm
    M Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm
    M Source/bmalloc/bmalloc/TZoneHeap.cpp
    M Source/bmalloc/bmalloc/TZoneHeap.h
    M Source/bmalloc/bmalloc/TZoneHeapInlines.h
    M Source/bmalloc/bmalloc/TZoneHeapManager.cpp
    M Source/bmalloc/bmalloc/TZoneHeapManager.h

  Log Message:
  -----------
  Remove unneeded HeapRef pre-initialization.
https://bugs.webkit.org/show_bug.cgi?id=285884
rdar://142842564

Reviewed by Keith Miller.

AB tests show that this optimization that I added does not add any value.  So, I'm removing it
to clean up and simplify the code.

* Source/JavaScriptCore/runtime/InitializeThreading.cpp:
(JSC::initialize):
* Source/WTF/wtf/TZoneMalloc.h:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/platform/WebCoreHeapSupport.cpp: Removed.
* Source/WebCore/platform/WebCoreHeapSupport.h: Removed.
* Source/WebCore/platform/ios/wak/WebCoreThread.mm:
(RunWebThread):
* Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm:
(WebKit::XPCServiceInitializerDelegate::XPCServiceInitializerDelegate):
* Source/bmalloc/bmalloc/TZoneHeap.cpp:
(bmalloc::api::tzonePreInitializeHeapRefs): Deleted.
* Source/bmalloc/bmalloc/TZoneHeap.h:
* Source/bmalloc/bmalloc/TZoneHeapInlines.h:
* Source/bmalloc/bmalloc/TZoneHeapManager.cpp:
(bmalloc::api::TZoneHeapManager::preInitializeHeapRefs): Deleted.
* Source/bmalloc/bmalloc/TZoneHeapManager.h:

Canonical link: https://commits.webkit.org/288846@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list