[webkit-changes] [WebKit/WebKit] 0eb263: Followup to 288814 at main — use `ScrollableArea::scr...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0eb2638e33f0edc89bbfe88cc51821684d1fe6c2
      https://github.com/WebKit/WebKit/commit/0eb2638e33f0edc89bbfe88cc51821684d1fe6c2
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2025-01-13 (Mon, 13 Jan 2025)

  Changed paths:
    M Source/WebKit/Shared/EditorState.h
    M Source/WebKit/Shared/EditorState.serialization.in
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm
    M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm

  Log Message:
  -----------
  Followup to 288814 at main — use `ScrollableArea::scrollOffset()` instead of manually computing scroll offset from position
https://bugs.webkit.org/show_bug.cgi?id=285879

Reviewed by Abrar Rahman Protyasha and Megan Gardner.

Use `scrollOffset()` instead of `scrollOrigin() + scrollPosition()`, since the former is more
concise. Additionally rename `enclosingScroll{Position → Offset}` to reflect that this represents a
scroll offset (as opposed to a scroll position).

* Source/WebKit/Shared/EditorState.h:
* Source/WebKit/Shared/EditorState.serialization.in:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _reconcileEnclosingScrollViewContentOffset:]):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::platformPopulateEditorStateIfNeeded const):
* Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::computeEnclosingLayerID const):

Canonical link: https://commits.webkit.org/288828@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications