[webkit-changes] [WebKit/WebKit] 0aed73: [Skia] ASSERTION FAILED: bitmap->size() == updateS...

Fujii Hironori noreply at github.com
Mon Jan 13 13:18:06 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0aed7355305100f4556cf85f23d5ab3b4696ad3a
      https://github.com/WebKit/WebKit/commit/0aed7355305100f4556cf85f23d5ab3b4696ad3a
  Author: Fujii Hironori <Hironori.Fujii at sony.com>
  Date:   2025-01-13 (Mon, 13 Jan 2025)

  Changed paths:
    M Source/WebKit/UIProcess/skia/BackingStoreSkia.cpp

  Log Message:
  -----------
  [Skia] ASSERTION FAILED: bitmap->size() == updateSize : BackingStore::incorporateUpdate(UpdateInfo &&) on a fractional device scale factor display
https://bugs.webkit.org/show_bug.cgi?id=285718

Reviewed by Don Olmstead.

Windows supports fractional device scale factors. For example, 125%,
150% and 175% DPI display. BackingStore::incorporateUpdate has an
assertion that checkes a ShareableBitmap size is the bounding rect
size scaled by the device scale factor. However, this assertion failed
if the device scale factor was fractional.

<https://commits.webkit.org/279794@main> added `expandedIntSize` to
BackingStoreCairo.cpp to solve a same problem. Did the same for
BackingStoreSkia.cpp.

* Source/WebKit/UIProcess/skia/BackingStoreSkia.cpp:
(WebKit::BackingStore::incorporateUpdate):

Canonical link: https://commits.webkit.org/288818@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list