[webkit-changes] [WebKit/WebKit] e2f579: Fix wpt/css/css-position/position-absolute-margin-...

Alan Baradlay noreply at github.com
Mon Jan 13 05:18:04 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e2f5796629cb8e11ceacc47c03ba4ea125fc3fac
      https://github.com/WebKit/WebKit/commit/e2f5796629cb8e11ceacc47c03ba4ea125fc3fac
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2025-01-13 (Mon, 13 Jan 2025)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-absolute-margin-auto-001-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-absolute-margin-auto-001.html
    M Source/WebCore/rendering/RenderBox.cpp

  Log Message:
  -----------
  Fix wpt/css/css-position/position-absolute-margin-auto-001.html
https://bugs.webkit.org/show_bug.cgi?id=285135
<rdar://problem/142214631>

Reviewed by Antti Koivisto.

This patch ensure that we run the correct logic for over-constrained cases when the absolute positioned box is a writing-mode root.
For more details check webkit.org/b/285803

(Test case credit goes to https://chromium.googlesource.com/chromium/src/+/6e97626524ac080b7cc6cd6a7dc27031f0864d64

* LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-absolute-margin-auto-001-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-position/position-absolute-margin-auto-001.html: Added.
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::computePositionedLogicalWidthUsing const):
(WebCore::RenderBox::computePositionedLogicalHeightUsing const):

Canonical link: https://commits.webkit.org/288797@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list