[webkit-changes] [WebKit/WebKit] 2a171b: [scroll-animations] WPT test scroll-animations/vie...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2a171bab90e5b293278fde7c2969ddcfc2ebdda1
      https://github.com/WebKit/WebKit/commit/2a171bab90e5b293278fde7c2969ddcfc2ebdda1
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2025-01-13 (Mon, 13 Jan 2025)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/scroll-animations/view-timelines/view-timeline-inset-expected.txt
    M Source/WebCore/animation/ViewTimeline.cpp
    M Source/WebCore/animation/ViewTimeline.h
    M Source/WebCore/animation/ViewTimeline.idl
    M Source/WebCore/animation/ViewTimelineOptions.h
    M Source/WebCore/animation/ViewTimelineOptions.idl

  Log Message:
  -----------
  [scroll-animations] WPT test scroll-animations/view-timelines/view-timeline-inset.html is a failure
https://bugs.webkit.org/show_bug.cgi?id=285750
rdar://142690868

Reviewed by Anne van Kesteren.

Our support for view timeline insets was very rudimentary. While we fixed the most egregious issue in 288684 at main,
we still had many issues left as shown in the failures in the relevant WPT test.

The main task was to only convert inset values provided via the JS bindings to `CSSPrimitiveValue` such that we may
resolve the insets when the view timeline's current time is being recomputed, thus correctly handling any relative
value. Values provided via CSS are already fully resolved and are used as-is.

We also implement the behavior where an `"auto"` values means that the values provided through the `scroll-padding`
CSS property on the scroll container should be used.

Additionally, we now raise exceptions for forbidden value types and units.

We also switched the IDL type for `ViewTimelineInsets.inset` to use a `CSSKeywordish` rather than `CSSKeywordValue`
alone so that strings would be allowed. This matches what Chrome implements and one of the cases tested in the test.
The issue https://github.com/w3c/csswg-drafts/issues/11477 was filed to track resolution of this discrepancy between
the spec and WPT.

* LayoutTests/imported/w3c/web-platform-tests/scroll-animations/view-timelines/view-timeline-inset-expected.txt:
* Source/WebCore/animation/ViewTimeline.cpp:
(WebCore::isValidInset):
(WebCore::ViewTimeline::create):
(WebCore::ViewTimeline::ViewTimeline):
(WebCore::ViewTimeline::validateSpecifiedInsets):
(WebCore::ViewTimeline::cacheCurrentTime):
(WebCore::lengthForInset): Deleted.
(WebCore::insetsFromOptions): Deleted.
* Source/WebCore/animation/ViewTimeline.h:
* Source/WebCore/animation/ViewTimeline.idl:
* Source/WebCore/animation/ViewTimelineOptions.h:
* Source/WebCore/animation/ViewTimelineOptions.idl:

Canonical link: https://commits.webkit.org/288795@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications