[webkit-changes] [WebKit/WebKit] 1021b2: [GTK][WPE][Skia] Visiting wpewebkit.org with Skia/...

[Nikolas Zimmermann]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1021b2c0a05a9e191f3faad0d531952817579046
      https://github.com/WebKit/WebKit/commit/1021b2c0a05a9e191f3faad0d531952817579046
  Author: Nikolas Zimmermann <nzimmermann at igalia.com>
  Date:   2025-01-12 (Sun, 12 Jan 2025)

  Changed paths:
    M Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp

  Log Message:
  -----------
  [GTK][WPE][Skia] Visiting wpewebkit.org with Skia/CPU rendering fires assertion
https://bugs.webkit.org/show_bug.cgi?id=285768

Reviewed by Adrian Perez de Castro.

drawFilteredImageBuffer() tries to determine if it needs to copy the
ImageBuffer backend of the accelerated image, in case of cross-thread
usage (e.g. re-wrapping an existing GPU resource in another thread).
This erroneously ran also for unaccelerated rendering, firing an
assertion that the SkiaGLContext is not available, which is correct. We
shouldn't attempt to run the copy-ImageBuffer-backend logic during
unaccelerated rendering -- fix that.

* Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContextSkia::drawFilteredImageBuffer):

Canonical link: https://commits.webkit.org/288778@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications