[webkit-changes] [WebKit/WebKit] d4c07d: Make type conversion explicit when using RectEdges

[Sam Weinig]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d4c07d7b0c8db793e13e563c3f917000eaa8e670
      https://github.com/WebKit/WebKit/commit/d4c07d7b0c8db793e13e563c3f917000eaa8e670
  Author: Sam Weinig <sam at webkit.org>
  Date:   2025-01-11 (Sat, 11 Jan 2025)

  Changed paths:
    M Source/WebCore/html/canvas/CanvasLayerContextSwitcher.cpp
    M Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp
    M Source/WebCore/page/DebugPageOverlays.cpp
    M Source/WebCore/platform/FloatConversion.h
    M Source/WebCore/platform/LengthBox.h
    M Source/WebCore/platform/RectEdges.h
    M Source/WebCore/svg/SVGFEMorphologyElement.cpp
    M Source/WebKit/Shared/gtk/PrintInfoGtk.cpp
    M Source/WebKit/Shared/mac/PrintInfoMac.mm
    M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm
    M Source/WebKit/UIProcess/ios/WKContentView.mm
    M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm
    M Source/WebKit/UIProcess/mac/WebViewImpl.mm
    M Source/WebKitLegacy/mac/WebView/WebView.mm

  Log Message:
  -----------
  Make type conversion explicit when using RectEdges
https://bugs.webkit.org/show_bug.cgi?id=285790

Reviewed by Darin Adler.

Make RectEdges more consistent with other WebCore types by removing
implicit numeric conversions. Instead, require callers to explicitly
convert values as normal.

Originally motivated by needing to fix RectEdges forwarding constructor
to forward using the deduced type, which this change also addresses.

* Source/WebCore/html/canvas/CanvasLayerContextSwitcher.cpp:
* Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:
* Source/WebCore/page/DebugPageOverlays.cpp:
* Source/WebCore/platform/LengthBox.h:
* Source/WebCore/platform/RectEdges.h:
* Source/WebCore/svg/SVGFEMorphologyElement.cpp:
* Source/WebKit/Shared/gtk/PrintInfoGtk.cpp:
* Source/WebKit/Shared/mac/PrintInfoMac.mm:
* Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:
* Source/WebKit/UIProcess/ios/WKContentView.mm:
* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
* Source/WebKitLegacy/mac/WebView/WebView.mm:

Canonical link: https://commits.webkit.org/288763@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications