[webkit-changes] [WebKit/WebKit] 5592e5: [WebGPU] draw call of single vertex with buffer si...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5592e533ed0ff0655ba6f8f0c229ad8e4a8317ec
      https://github.com/WebKit/WebKit/commit/5592e533ed0ff0655ba6f8f0c229ad8e4a8317ec
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2025-01-10 (Fri, 10 Jan 2025)

  Changed paths:
    A LayoutTests/fast/webgpu/regression/repro_285464-expected.txt
    A LayoutTests/fast/webgpu/regression/repro_285464.html
    M Source/WebGPU/WebGPU/RenderBundleEncoder.h
    M Source/WebGPU/WebGPU/RenderBundleEncoder.mm
    M Source/WebGPU/WebGPU/RenderPassEncoder.h
    M Source/WebGPU/WebGPU/RenderPassEncoder.mm
    M Source/WebGPU/WebGPU/RenderPipeline.h
    M Source/WebGPU/WebGPU/RenderPipeline.mm

  Log Message:
  -----------
  [WebGPU] draw call of single vertex with buffer size less than stride triggers a validation error
https://bugs.webkit.org/show_bug.cgi?id=285464
rdar://128599796

Reviewed by Dan Glastonbury.

It would seem this is a validation layer error only, but in the rare case
a buffer is set which contains only a single vertex, the validation layer
will report an error when stride > max(lastStride, bufferSize).

To fix this, we can clone the PSO and rewrite stride to be equal to lastStride.

* LayoutTests/fast/webgpu/regression/repro_285464-expected.txt: Added.
* LayoutTests/fast/webgpu/regression/repro_285464.html: Added.
Add regression test.

* Source/WebGPU/WebGPU/RenderBundleEncoder.h:
* Source/WebGPU/WebGPU/RenderBundleEncoder.mm:
(WebGPU::RenderBundleEncoder::executePreDrawCommands):
(WebGPU::RenderBundleEncoder::draw):
(WebGPU::RenderBundleEncoder::computeMininumVertexInstanceCount const):
(WebGPU::RenderBundleEncoder::storeVertexBufferCountsForValidation):
(WebGPU::RenderBundleEncoder::drawIndexed):
(WebGPU::RenderBundleEncoder::drawIndexedIndirect):
(WebGPU::RenderBundleEncoder::drawIndirect):
* Source/WebGPU/WebGPU/RenderPassEncoder.h:
* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::executePreDrawCommands):
(WebGPU::RenderPassEncoder::draw):
(WebGPU::RenderPassEncoder::computeMininumVertexInstanceCount):
(WebGPU::RenderPassEncoder::computeMininumVertexInstanceCount const):
(WebGPU::RenderPassEncoder::clampIndexBufferToValidValues):
(WebGPU::RenderPassEncoder::drawIndexed):
(WebGPU::RenderPassEncoder::drawIndexedIndirect):
(WebGPU::RenderPassEncoder::drawIndirect):
* Source/WebGPU/WebGPU/RenderPipeline.h:
* Source/WebGPU/WebGPU/RenderPipeline.mm:
(WebGPU::RenderPipeline::recomputeLastStrideAsStride const):

Canonical link: https://commits.webkit.org/288748@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications