[webkit-changes] [WebKit/WebKit] 20c4db: [JSC] Remove useWasmGC option

Yusuke Suzuki noreply at github.com
Fri Jan 10 17:27:30 PST 2025 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 20c4db232be790ebc8a44a769603906afe970ef0
      https://github.com/WebKit/WebKit/commit/20c4db232be790ebc8a44a769603906afe970ef0
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2025-01-10 (Fri, 10 Jan 2025)

  Changed paths:
    M JSTests/wasm/gc/any.js
    M JSTests/wasm/gc/array_new_data.js
    M JSTests/wasm/gc/array_new_elem.js
    M JSTests/wasm/gc/array_new_fixed.js
    M JSTests/wasm/gc/array_new_fixed_long.js
    M JSTests/wasm/gc/arrays.js
    M JSTests/wasm/gc/block.js
    M JSTests/wasm/gc/br_on_cast.js
    M JSTests/wasm/gc/bug137224743.js
    M JSTests/wasm/gc/bug138038945.js
    M JSTests/wasm/gc/bug247874.js
    M JSTests/wasm/gc/bug250613.js
    M JSTests/wasm/gc/bug252299.js
    M JSTests/wasm/gc/bug252538.js
    M JSTests/wasm/gc/bug252719.js
    M JSTests/wasm/gc/bug254226.js
    M JSTests/wasm/gc/bug254412.js
    M JSTests/wasm/gc/bug254413.js
    M JSTests/wasm/gc/bug254414.js
    M JSTests/wasm/gc/bug258127.js
    M JSTests/wasm/gc/bug258128.js
    M JSTests/wasm/gc/bug258499.js
    M JSTests/wasm/gc/bug258795.js
    M JSTests/wasm/gc/bug258796.js
    M JSTests/wasm/gc/bug258801.js
    M JSTests/wasm/gc/bug258804.js
    M JSTests/wasm/gc/bug258805.js
    M JSTests/wasm/gc/bug260516.js
    M JSTests/wasm/gc/bug262862.js
    M JSTests/wasm/gc/bug262863.js
    M JSTests/wasm/gc/bug265721.js
    M JSTests/wasm/gc/bug265742.js
    M JSTests/wasm/gc/bug265927.js
    M JSTests/wasm/gc/bug266043.js
    M JSTests/wasm/gc/bug266056.js
    M JSTests/wasm/gc/bug266127.js
    M JSTests/wasm/gc/bug266167.js
    M JSTests/wasm/gc/bug266249.js
    M JSTests/wasm/gc/bug267381.js
    M JSTests/wasm/gc/bulk-array.js
    M JSTests/wasm/gc/call_indirect.js
    M JSTests/wasm/gc/call_ref.js
    M JSTests/wasm/gc/casts.js
    M JSTests/wasm/gc/const-exprs.js
    M JSTests/wasm/gc/eq.js
    M JSTests/wasm/gc/exception.js
    M JSTests/wasm/gc/extern.js
    M JSTests/wasm/gc/i31.js
    M JSTests/wasm/gc/js-api.js
    M JSTests/wasm/gc/limits.js
    M JSTests/wasm/gc/linking.js
    M JSTests/wasm/gc/packed-arrays.js
    M JSTests/wasm/gc/rec.js
    M JSTests/wasm/gc/simd.js
    M JSTests/wasm/gc/structs.js
    M JSTests/wasm/gc/sub.js
    M JSTests/wasm/gc/subtyping.js
    M JSTests/wasm/gc/table_init.js
    M JSTests/wasm/references/element_active_mod.js
    M JSTests/wasm/references/func_ref.js
    M JSTests/wasm/references/is_null.js
    M JSTests/wasm/references/table_misc.js
    M JSTests/wasm/references/validation.js
    M JSTests/wasm/stress/multiple-recgroups.js
    M Source/JavaScriptCore/runtime/JSGlobalObject.h
    M Source/JavaScriptCore/runtime/Options.cpp
    M Source/JavaScriptCore/runtime/OptionsList.h
    M Source/JavaScriptCore/wasm/WasmBBQJIT.cpp
    M Source/JavaScriptCore/wasm/WasmConstExprGenerator.cpp
    M Source/JavaScriptCore/wasm/WasmFormat.h
    M Source/JavaScriptCore/wasm/WasmFunctionParser.h
    M Source/JavaScriptCore/wasm/WasmOMGIRGenerator.cpp
    M Source/JavaScriptCore/wasm/WasmOMGIRGenerator32_64.cpp
    M Source/JavaScriptCore/wasm/WasmOperations.cpp
    M Source/JavaScriptCore/wasm/WasmSectionParser.cpp
    M Source/JavaScriptCore/wasm/WasmTable.cpp
    M Source/JavaScriptCore/wasm/WasmTypeDefinition.cpp
    M Source/JavaScriptCore/wasm/js/JSWebAssemblyHelpers.h
    M Source/JavaScriptCore/wasm/js/WasmToJS.cpp
    M Source/JavaScriptCore/wasm/js/WebAssemblyModuleRecord.cpp
    M Tools/Scripts/run-jsc-stress-tests

  Log Message:
  -----------
  [JSC] Remove useWasmGC option
https://bugs.webkit.org/show_bug.cgi?id=285786
rdar://142715924

Reviewed by Yijia Huang.

There are terrible WasmFormat.h's Options::useWasmGC related code for
0/1 and they were some of cause of bugs so far. We should wipe them as
soon as possible. This patch removes useWasmGC and always enabling it.

* JSTests/wasm/gc/any.js:
* JSTests/wasm/gc/array_new_data.js:
* JSTests/wasm/gc/array_new_elem.js:
* JSTests/wasm/gc/array_new_fixed.js:
* JSTests/wasm/gc/array_new_fixed_long.js:
* JSTests/wasm/gc/arrays.js:
* JSTests/wasm/gc/block.js:
* JSTests/wasm/gc/br_on_cast.js:
* JSTests/wasm/gc/bug137224743.js:
* JSTests/wasm/gc/bug138038945.js:
* JSTests/wasm/gc/bug247874.js:
* JSTests/wasm/gc/bug250613.js:
* JSTests/wasm/gc/bug252299.js:
* JSTests/wasm/gc/bug252538.js:
* JSTests/wasm/gc/bug252719.js:
* JSTests/wasm/gc/bug254226.js:
* JSTests/wasm/gc/bug254412.js:
* JSTests/wasm/gc/bug254413.js:
* JSTests/wasm/gc/bug254414.js:
* JSTests/wasm/gc/bug258127.js:
* JSTests/wasm/gc/bug258128.js:
* JSTests/wasm/gc/bug258499.js:
* JSTests/wasm/gc/bug258795.js:
* JSTests/wasm/gc/bug258796.js:
* JSTests/wasm/gc/bug258801.js:
* JSTests/wasm/gc/bug258804.js:
* JSTests/wasm/gc/bug258805.js:
* JSTests/wasm/gc/bug260516.js:
* JSTests/wasm/gc/bug262862.js:
* JSTests/wasm/gc/bug262863.js:
* JSTests/wasm/gc/bug265721.js:
* JSTests/wasm/gc/bug265742.js:
* JSTests/wasm/gc/bug265927.js:
* JSTests/wasm/gc/bug266043.js:
* JSTests/wasm/gc/bug266056.js:
* JSTests/wasm/gc/bug266127.js:
* JSTests/wasm/gc/bug266167.js:
* JSTests/wasm/gc/bug266249.js:
* JSTests/wasm/gc/bug267381.js:
* JSTests/wasm/gc/bulk-array.js:
* JSTests/wasm/gc/call_indirect.js:
* JSTests/wasm/gc/call_ref.js:
* JSTests/wasm/gc/casts.js:
* JSTests/wasm/gc/const-exprs.js:
* JSTests/wasm/gc/eq.js:
* JSTests/wasm/gc/exception.js:
* JSTests/wasm/gc/extern.js:
* JSTests/wasm/gc/i31.js:
* JSTests/wasm/gc/js-api.js:
* JSTests/wasm/gc/limits.js:
* JSTests/wasm/gc/linking.js:
* JSTests/wasm/gc/packed-arrays.js:
* JSTests/wasm/gc/rec.js:
* JSTests/wasm/gc/simd.js:
* JSTests/wasm/gc/structs.js:
* JSTests/wasm/gc/sub.js:
* JSTests/wasm/gc/subtyping.js:
* JSTests/wasm/gc/table_init.js:
* JSTests/wasm/references/element_active_mod.js:
* JSTests/wasm/references/func_ref.js:
* JSTests/wasm/references/is_null.js:
* JSTests/wasm/references/table_misc.js:
* JSTests/wasm/references/validation.js:
* JSTests/wasm/stress/multiple-recgroups.js:
* Source/JavaScriptCore/runtime/JSGlobalObject.h:
* Source/JavaScriptCore/runtime/Options.cpp:
(JSC::disableAllWasmOptions):
* Source/JavaScriptCore/runtime/OptionsList.h:
* Source/JavaScriptCore/wasm/WasmBBQJIT.cpp:
(JSC::Wasm::BBQJITImpl::BBQJIT::emitSlowPathRTTCheck):
(JSC::Wasm::BBQJITImpl::BBQJIT::addCallIndirect):
* Source/JavaScriptCore/wasm/WasmConstExprGenerator.cpp:
(JSC::Wasm::ConstExprGenerator::getGlobal):
(JSC::Wasm::ConstExprGenerator::addArrayNew):
(JSC::Wasm::ConstExprGenerator::addArrayNewDefault):
(JSC::Wasm::ConstExprGenerator::addArrayNewFixed):
(JSC::Wasm::ConstExprGenerator::addStructNewDefault):
(JSC::Wasm::ConstExprGenerator::addStructNew):
(JSC::Wasm::ConstExprGenerator::addAnyConvertExtern):
(JSC::Wasm::ConstExprGenerator::addExternConvertAny):
* Source/JavaScriptCore/wasm/WasmFormat.h:
(JSC::Wasm::isEqref):
(JSC::Wasm::isAnyref):
(JSC::Wasm::isNullref):
(JSC::Wasm::isNullfuncref):
(JSC::Wasm::isNullexternref):
(JSC::Wasm::isInternalref):
(JSC::Wasm::isI31ref):
(JSC::Wasm::isArrayref):
(JSC::Wasm::isStructref):
(JSC::Wasm::eqrefType):
(JSC::Wasm::anyrefType):
(JSC::Wasm::arrayrefType):
(JSC::Wasm::isRefWithRecursiveReference):
(JSC::Wasm::isSubtypeIndex):
(JSC::Wasm::isValidHeapTypeKind):
* Source/JavaScriptCore/wasm/WasmFunctionParser.h:
(JSC::Wasm::FunctionParser<Context>::parseExpression):
(JSC::Wasm::FunctionParser<Context>::parseUnreachableExpression):
* Source/JavaScriptCore/wasm/WasmOMGIRGenerator.cpp:
(JSC::Wasm::OMGIRGenerator::addCallIndirect):
* Source/JavaScriptCore/wasm/WasmOMGIRGenerator32_64.cpp:
(JSC::Wasm::OMGIRGenerator::addCallIndirect):
* Source/JavaScriptCore/wasm/WasmOperations.cpp:
(JSC::Wasm::JSC_DEFINE_JIT_OPERATION):
(JSC::Wasm::JSC_DEFINE_NOEXCEPT_JIT_OPERATION):
* Source/JavaScriptCore/wasm/WasmSectionParser.cpp:
(JSC::Wasm::SectionParser::parseType):
(JSC::Wasm::SectionParser::parseInitExpr):
(JSC::Wasm::SectionParser::parseStorageType):
(JSC::Wasm::SectionParser::parseStructType):
(JSC::Wasm::SectionParser::parseArrayType):
(JSC::Wasm::SectionParser::parseRecursionGroup):
(JSC::Wasm::SectionParser::parseSubtype):
* Source/JavaScriptCore/wasm/WasmTable.cpp:
(JSC::Wasm::ExternOrAnyRefTable::ExternOrAnyRefTable):
* Source/JavaScriptCore/wasm/WasmTypeDefinition.cpp:
(JSC::Wasm::TypeInformation::TypeInformation):
(JSC::Wasm::TypeInformation::getCanonicalRTT):
* Source/JavaScriptCore/wasm/js/JSWebAssemblyHelpers.h:
(JSC::toWebAssemblyValue):
* Source/JavaScriptCore/wasm/js/WasmToJS.cpp:
(JSC::Wasm::wasmToJS):
* Source/JavaScriptCore/wasm/js/WebAssemblyModuleRecord.cpp:
(JSC::WebAssemblyModuleRecord::initializeImports):
(JSC::WebAssemblyModuleRecord::initializeExports):
* Tools/Scripts/run-jsc-stress-tests:

Canonical link: https://commits.webkit.org/288744@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications

More information about the webkit-changes mailing list