[webkit-changes] [WebKit/WebKit] 74f3a2: WebKitTestRunner should generate crash logs when M...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 74f3a290cc3ff942d4662652fa33348183c3a005
      https://github.com/WebKit/WebKit/commit/74f3a290cc3ff942d4662652fa33348183c3a005
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2025-01-10 (Fri, 10 Jan 2025)

  Changed paths:
    M Source/WebKit/Platform/IPC/Connection.cpp
    M Source/WebKit/Platform/IPC/Connection.h
    M Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKProcessPoolPrivate.h
    M Tools/WebKitTestRunner/ios/mainIOS.mm
    M Tools/WebKitTestRunner/mac/main.mm

  Log Message:
  -----------
  WebKitTestRunner should generate crash logs when MESSAGE_CHECK fails
https://bugs.webkit.org/show_bug.cgi?id=285716
rdar://142653486

Reviewed by Charlie Wolfe.

Particularly with site isolation tests, we occasionally see crashes in the test results
but no crash logs.  This will make it so that if the "crash" comes from a MESSAGE_CHECK,
we will be able to see from a crash log which check failed to investigate and fix.

* Source/WebKit/Platform/IPC/Connection.cpp:
(IPC::Connection::shouldCrashOnMessageCheckFailure):
(IPC::Connection::setShouldCrashOnMessageCheckFailure):
* Source/WebKit/Platform/IPC/Connection.h:
* Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm:
(+[WKProcessPool _crashOnMessageCheckFailureForTesting]):
* Source/WebKit/UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
* Tools/WebKitTestRunner/ios/mainIOS.mm:
(main):
* Tools/WebKitTestRunner/mac/main.mm:
(main):

Canonical link: https://commits.webkit.org/288733@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications