[webkit-changes] [WebKit/WebKit] 150944: Add null check in NetworkRTCTCPSocketCocoa::getInt...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1509442429c6f3465f4f920c78de51b150f1a000
      https://github.com/WebKit/WebKit/commit/1509442429c6f3465f4f920c78de51b150f1a000
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2025-01-10 (Fri, 10 Jan 2025)

  Changed paths:
    M Source/WebKit/NetworkProcess/webrtc/NetworkRTCTCPSocketCocoa.mm

  Log Message:
  -----------
  Add null check in NetworkRTCTCPSocketCocoa::getInterfaceName
https://bugs.webkit.org/show_bug.cgi?id=285696
rdar://142628299

Reviewed by Youenn Fablet.

I saw a crash indicating the CompletionHandler was null in the callOnRTCNetworkThread call.
This might be because nw_connection_cancel is calling the state changed handler synchronously
sometimes.  To prevent multiple calls, set nwConnection to null before calling nw_connection_cancel.

* Source/WebKit/NetworkProcess/webrtc/NetworkRTCTCPSocketCocoa.mm:
(WebKit::NetworkRTCTCPSocketCocoa::getInterfaceName):

Canonical link: https://commits.webkit.org/288732@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications