[webkit-changes] [WebKit/WebKit] 23337c: [WebKit] Avoid running "Generate Derived Sources" ...

Elliott Williams noreply at github.com
Fri Jan 10 12:38:32 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 23337c88dde5c88452e82c0ad0170820cbf92218
      https://github.com/WebKit/WebKit/commit/23337c88dde5c88452e82c0ad0170820cbf92218
  Author: Elliott Williams <emw at apple.com>
  Date:   2025-01-10 (Fri, 10 Jan 2025)

  Changed paths:
    M Source/WebKit/DerivedSources-input.xcfilelist
    M Source/WebKit/DerivedSources-output.xcfilelist
    M Source/WebKit/DerivedSources.make
    M Source/WebKit/Modules/iOS_Private.modulemap
    M Source/WebKit/Scripts/generate-derived-sources.sh
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  -----------
  [WebKit] Avoid running "Generate Derived Sources" in installhdrs phases
https://bugs.webkit.org/show_bug.cgi?id=285641
rdar://problem/142584488

Reviewed by Alexey Proskuryakov.

Most of the sources generated are only needed at compilation time.
Apple's internal build system installs headers prior to building WebKit,
so we save time and eliminate some dependencies by preventing the
Makefile from building during installhdrs.

One file that *does* appear to be needed during installhdrs is the
module map. Move its build logic out to a separate script phase.

* Source/WebKit/DerivedSources-input.xcfilelist:
* Source/WebKit/DerivedSources-output.xcfilelist:
* Source/WebKit/DerivedSources.make:
* Source/WebKit/Modules/iOS_Private.modulemap: Change unifdef-style
  feature check to WTF style, as this file is now processed by clang
  directly, not unifdef.
* Source/WebKit/Scripts/generate-derived-sources.sh:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/288724@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list