[webkit-changes] [WebKit/WebKit] 42bb32: URLPattern match should apply https://urlpattern.s...

youennf noreply at github.com
Fri Jan 10 11:04:13 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 42bb322c572d02cdf66a41dee0606383be2f70fb
      https://github.com/WebKit/WebKit/commit/42bb322c572d02cdf66a41dee0606383be2f70fb
  Author: Youenn Fablet <youenn at apple.com>
  Date:   2025-01-10 (Fri, 10 Jan 2025)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/urlpattern/urlpattern.any-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/urlpattern/urlpattern.any.serviceworker-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/urlpattern/urlpattern.any.sharedworker-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/urlpattern/urlpattern.any.worker-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/urlpattern/urlpattern.https.any-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/urlpattern/urlpattern.https.any.serviceworker-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/urlpattern/urlpattern.https.any.sharedworker-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/urlpattern/urlpattern.https.any.worker-expected.txt
    M Source/WebCore/Modules/url-pattern/URLPattern.cpp

  Log Message:
  -----------
  URLPattern match should apply https://urlpattern.spec.whatwg.org/#process-a-urlpatterninit
https://bugs.webkit.org/show_bug.cgi?id=285692
rdar://142619809

Reviewed by Chris Dumez.

As per spec, we need to apply https://urlpattern.spec.whatwg.org/#process-a-urlpatterninit when trying to match a URLPatternInit,
as per https://urlpattern.spec.whatwg.org/#url-pattern-match step 11.2.
This makes sure to canonicalize the input before doing the match.

Covered by rebased tests.

* LayoutTests/imported/w3c/web-platform-tests/urlpattern/urlpattern.any-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/urlpattern/urlpattern.any.serviceworker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/urlpattern/urlpattern.any.sharedworker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/urlpattern/urlpattern.any.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/urlpattern/urlpattern.https.any-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/urlpattern/urlpattern.https.any.serviceworker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/urlpattern/urlpattern.https.any.sharedworker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/urlpattern/urlpattern.https.any.worker-expected.txt:
* Source/WebCore/Modules/url-pattern/URLPattern.cpp:
(WebCore::processProtocolForInit):
(WebCore::processUsernameForInit):
(WebCore::processPasswordForInit):
(WebCore::processHostnameForInit):

Canonical link: https://commits.webkit.org/288721@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list