[webkit-changes] [WebKit/WebKit] 8bcd72: Add overload of MetaConsumer::consume that allows ...

[Sam Weinig]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8bcd72ff0abb3d065f934d789b5c97d3fb0470e1
      https://github.com/WebKit/WebKit/commit/8bcd72ff0abb3d065f934d789b5c97d3fb0470e1
  Author: Sam Weinig <sam at webkit.org>
  Date:   2025-01-10 (Fri, 10 Jan 2025)

  Changed paths:
    M Source/WebCore/css/parser/CSSPropertyParserConsumer+Font.cpp
    M Source/WebCore/css/parser/CSSPropertyParserConsumer+Image.cpp
    M Source/WebCore/css/parser/CSSPropertyParserConsumer+MetaConsumer.h
    M Source/WebCore/css/values/primitives/CSSPrimitiveNumericRaw.h
    M Source/WebCore/css/values/primitives/CSSPrimitiveNumericTypes.h

  Log Message:
  -----------
  Add overload of MetaConsumer::consume that allows operating directly on consumed values without going through a std::variant
https://bugs.webkit.org/show_bug.cgi?id=285707

Reviewed by Darin Adler.

As code site simplification and as an optimization to avoid extra variant
dispatch, add overload of MetaConsumer::consume that allows operating directly
on consumed values without going through a std::variant.

* Source/WebCore/css/parser/CSSPropertyParserConsumer+MetaConsumer.h:
    - Implement consume with a functor and re-implement the old version
      as a call to the new one.

* Source/WebCore/css/parser/CSSPropertyParserConsumer+Font.cpp:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Image.cpp:
    - Adopt new overload to prove it out.

* Source/WebCore/css/values/primitives/CSSPrimitiveNumericRaw.h:
* Source/WebCore/css/values/primitives/CSSPrimitiveNumericTypes.h:
    - Add protection from passing CSSValueID to CSS::Numeric and CSS::NumericRaw.

Canonical link: https://commits.webkit.org/288714@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications