[webkit-changes] [WebKit/WebKit] 9b4956: [GStreamer] Get rid of GST_CALL_PARENT macros

Philippe Normand noreply at github.com
Fri Jan 10 01:01:06 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9b495619f313f45dad804224324ef48fa1b368d8
      https://github.com/WebKit/WebKit/commit/9b495619f313f45dad804224324ef48fa1b368d8
  Author: Philippe Normand <philn at igalia.com>
  Date:   2025-01-10 (Fri, 10 Jan 2025)

  Changed paths:
    M Source/WebCore/platform/SourcesGStreamer.txt
    M Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp
    M Source/WebCore/platform/graphics/gstreamer/GLVideoSinkGStreamer.cpp
    M Source/WebCore/platform/graphics/gstreamer/GStreamerSinksWorkarounds.cpp
    M Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp
    M Source/WebCore/platform/graphics/gstreamer/TextCombinerPadGStreamer.cpp
    M Source/WebCore/platform/graphics/gstreamer/TextSinkGStreamer.cpp
    M Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp
    M Source/WebCore/platform/graphics/gstreamer/WebKitAudioSinkGStreamer.cpp
    M Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp
    M Source/WebCore/platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp
    M Source/WebCore/platform/graphics/gstreamer/eme/WebKitThunderDecryptorGStreamer.cpp
    M Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp
    M Source/WebCore/platform/gstreamer/VideoEncoderPrivateGStreamer.cpp
    M Source/WebCore/platform/gstreamer/WebKitFliteSourceGStreamer.cpp
    M Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp
    M Source/WebCore/platform/mediastream/gstreamer/GStreamerMockDevice.cpp
    M Source/WebCore/platform/mediastream/gstreamer/GStreamerMockDeviceProvider.cpp

  Log Message:
  -----------
  [GStreamer] Get rid of GST_CALL_PARENT macros
https://bugs.webkit.org/show_bug.cgi?id=285665

Reviewed by Alicia Boya Garcia.

The GST_CALL_PARENT expects the presence of a parent_class variable, which we were mis-defining
everywhere (the #define was reversed). As this macro provides little value in the end, avoid using
it and we can now build our GStreamer object implementations as part of the unified build, after
de-duplicating the various GstStaticPadTemplate variable names and GObject property enum values
across the code-base.

* Source/WebCore/platform/SourcesGStreamer.txt:
* Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webKitWebAudioSrcConstructed):
* Source/WebCore/platform/graphics/gstreamer/GLVideoSinkGStreamer.cpp:
(webKitGLVideoSinkConstructed):
(webKitGLVideoSinkFinalize):
(webKitGLVideoSinkChangeState):
* Source/WebCore/platform/graphics/gstreamer/GStreamerSinksWorkarounds.cpp:
* Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp:
(webKitTextCombinerConstructed):
* Source/WebCore/platform/graphics/gstreamer/TextCombinerPadGStreamer.cpp:
(webkitTextCombinerPadConstructed):
* Source/WebCore/platform/graphics/gstreamer/TextSinkGStreamer.cpp:
(webkitTextSinkConstructed):
(webkitTextSinkQuery):
* Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(webkitVideoSinkConstructed):
(webkitVideoSinkUnlock):
(webkitVideoSinkUnlockStop):
(webkitVideoSinkEvent):
* Source/WebCore/platform/graphics/gstreamer/WebKitAudioSinkGStreamer.cpp:
(webKitAudioSinkChangeState):
(webKitAudioSinkConstructed):
* Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcConstructed):
(webKitWebSrcSetContext):
(webKitWebSrcQuery):
(webKitWebSrcEvent):
* Source/WebCore/platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp:
(constructed):
(sinkEventHandler):
(changeState):
(setContext):
* Source/WebCore/platform/graphics/gstreamer/eme/WebKitThunderDecryptorGStreamer.cpp:
* Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:
(webKitMediaSrcQuery):
(webKitMediaSrcConstructed):
* Source/WebCore/platform/gstreamer/VideoEncoderPrivateGStreamer.cpp:
(videoEncoderConstructed):
* Source/WebCore/platform/gstreamer/WebKitFliteSourceGStreamer.cpp:
(webkitFliteSrcConstructed):
* Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:
(webkitMediaStreamSrcConstructed):
(webkitMediaStreamSrcDispose):
(webkitMediaStreamSrcQuery):
* Source/WebCore/platform/mediastream/gstreamer/GStreamerMockDevice.cpp:
* Source/WebCore/platform/mediastream/gstreamer/GStreamerMockDeviceProvider.cpp:

Canonical link: https://commits.webkit.org/288690@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list