[webkit-changes] [WebKit/WebKit] 83a465: Ensure WebGL context drawing buffer EGL images are...

[Kimmo Kinnunen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 83a465951824ff92c746744f034c40948162c564
      https://github.com/WebKit/WebKit/commit/83a465951824ff92c746744f034c40948162c564
  Author: Kimmo Kinnunen <kkinnunen at apple.com>
  Date:   2025-01-09 (Thu, 09 Jan 2025)

  Changed paths:
    M Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm
    M Tools/TestWebKitAPI/Tests/WebCore/cocoa/TestGraphicsContextGLCocoa.mm

  Log Message:
  -----------
  Ensure WebGL context drawing buffer EGL images are always unbound with the underlying context current during destruction
https://bugs.webkit.org/show_bug.cgi?id=285671
rdar://122974634

Reviewed by Dan Glastonbury.

Make the underlying ANGLE OpenGL context current when unbinding the
drawing buffer. ReleaseTexImage should not need the context,
but ANGLE currently uses the context for flush purposes. Fixing ANGLE
is a large task.

* Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm:
(WebCore::GraphicsContextGLCocoa::~GraphicsContextGLCocoa):
(WebCore::GraphicsContextGLCocoa::freeDrawingBuffers):
* Tools/TestWebKitAPI/Tests/WebCore/cocoa/TestGraphicsContextGLCocoa.mm:
(TestWebKitAPI::TEST_F(GraphicsContextGLCocoaTest, DestroyWithoutMakingCurrent)):

Canonical link: https://commits.webkit.org/288682@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications