[webkit-changes] [WebKit/WebKit] ede962: [WebDriver][BiDi] Use "javascript" as the "type" p...

Lauro Moura noreply at github.com
Thu Jan 9 08:53:15 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ede962eba432f83c2b61d7383105929804a22d6c
      https://github.com/WebKit/WebKit/commit/ede962eba432f83c2b61d7383105929804a22d6c
  Author: Lauro Moura <lmoura at igalia.com>
  Date:   2025-01-09 (Thu, 09 Jan 2025)

  Changed paths:
    M Source/WebDriver/Session.cpp
    M Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp

  Log Message:
  -----------
  [WebDriver][BiDi] Use "javascript" as the "type" parameter when the message comes from a JavaScript error
https://bugs.webkit.org/show_bug.cgi?id=285028

Reviewed by Devin Rousso.

Use the `messageSource` field to check if the message is coming from a
JS error or from a regular console method.

Also set the `stackTrace` field for JS messages, as the spec requires
it.

* Source/WebDriver/Session.cpp:
(WebDriver::Session::doLogEntryAdded):
* Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::logEntryTypeForMessage):
(WebKit::WebAutomationSession::logEntryAdded):

Canonical link: https://commits.webkit.org/288666@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list