[webkit-changes] [WebKit/WebKit] cd7e70: [scroll-animations] setting a new progress-based t...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cd7e705f7687c5a170307275db9c6e99e6667018
      https://github.com/WebKit/WebKit/commit/cd7e705f7687c5a170307275db9c6e99e6667018
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2025-01-09 (Thu, 09 Jan 2025)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-ignored.tentative-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/scroll-animations/scroll-timelines/setting-timeline.tentative-expected.txt
    M LayoutTests/platform/glib/TestExpectations
    M LayoutTests/platform/win/TestExpectations
    M Source/WebCore/animation/WebAnimation.cpp

  Log Message:
  -----------
  [scroll-animations] setting a new progress-based timeline on an animation should reset its `ready` promise
https://bugs.webkit.org/show_bug.cgi?id=285667
rdar://142608438

Reviewed by Anne van Kesteren.

We were failing some scroll-animations WPT tests related to switching timelines dynamically because these tests
relied on the animation's `ready` promise being reset upon setting a new progress-based timeline. While the spec
doesn't currently state that this should occur, it makes sense that it would if the animation was not already
pending since a new start time will be computed in the next animation frame.

A spec issue was filed at https://github.com/w3c/csswg-drafts/issues/11465 to clear this up.

So when we schedule a pending play task, we also reset the `ready` promise in case the animation was not already
in the pending state.

* LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-ignored.tentative-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/scroll-animations/scroll-timelines/setting-timeline.tentative-expected.txt:
* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/win/TestExpectations:
* Source/WebCore/animation/WebAnimation.cpp:
(WebCore::WebAnimation::setTimeline):

Canonical link: https://commits.webkit.org/288655@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications