[webkit-changes] [WebKit/WebKit] 859231: REGRESSION (286320 at main): [iPadOS] YouTube in Safa...

Wenson Hsieh noreply at github.com
Wed Jan 8 18:55:50 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 859231d19f00572077958b0fa8ae90a10d9bafcd
      https://github.com/WebKit/WebKit/commit/859231d19f00572077958b0fa8ae90a10d9bafcd
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2025-01-08 (Wed, 08 Jan 2025)

  Changed paths:
    R LayoutTests/fast/events/touch/ios/content-observation/add-mouseout-event-listener-on-hover-expected.txt
    A LayoutTests/fast/events/touch/ios/content-observation/add-mouseout-event-listener-on-hover-quirk-expected.txt
    A LayoutTests/fast/events/touch/ios/content-observation/add-mouseout-event-listener-on-hover-quirk.html
    R LayoutTests/fast/events/touch/ios/content-observation/add-mouseout-event-listener-on-hover.html
    M Source/WebCore/page/Quirks.cpp
    M Source/WebCore/page/Quirks.h
    M Source/WebCore/page/QuirksData.h
    M Source/WebCore/page/ios/ContentChangeObserver.cpp

  Log Message:
  -----------
  REGRESSION (286320 at main): [iPadOS] YouTube in Safari requires two taps to start playback
https://bugs.webkit.org/show_bug.cgi?id=285633
rdar://140237391

Reviewed by Abrar Rahman Protyasha.

Guard the changes in 286320 at main, so that it's behind a site-specific quirk.

* Source/WebCore/page/ios/ContentChangeObserver.cpp:
(WebCore::ContentChangeObserver::didAddMouseMoveRelatedEventListener):

* LayoutTests/fast/events/touch/ios/content-observation/add-mouseout-event-listener-on-hover-quirk-expected.txt: Renamed from LayoutTests/fast/events/touch/ios/content-observation/add-mouseout-event-listener-on-hover-expected.txt.
* LayoutTests/fast/events/touch/ios/content-observation/add-mouseout-event-listener-on-hover-quirk.html: Renamed from LayoutTests/fast/events/touch/ios/content-observation/add-mouseout-event-listener-on-hover.html.

Keep this layout test passing by overriding the top document URL for the purposes of determining
active quirks. Additionally add a `-quirk` suffix to the name.

* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::shouldTreatAddingMouseOutEventListenerAsContentChange const):
(WebCore::handleSteamQuirks):
(WebCore::Quirks::determineRelevantQuirks):
* Source/WebCore/page/Quirks.h:
* Source/WebCore/page/QuirksData.h:

Remove an unused member variable.

* Source/WebCore/page/ios/ContentChangeObserver.cpp:
(WebCore::ContentChangeObserver::didAddMouseMoveRelatedEventListener):

Canonical link: https://commits.webkit.org/288627@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list