[webkit-changes] [WebKit/WebKit] a77d84: [WGSL] Floating point -> integer conversions shoul...

[Tadeu Zagallo]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a77d8458cec597d4cea6086410967c2bc118ee3d
      https://github.com/WebKit/WebKit/commit/a77d8458cec597d4cea6086410967c2bc118ee3d
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2025-01-08 (Wed, 08 Jan 2025)

  Changed paths:
    A LayoutTests/fast/webgpu/ftoi-expected.txt
    A LayoutTests/fast/webgpu/ftoi.html
    M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp
    M Source/WebGPU/WGSL/TypeCheck.cpp
    M Source/WebGPU/WGSL/WGSLShaderModule.h

  Log Message:
  -----------
  [WGSL] Floating point -> integer conversions should be bounds checked
https://bugs.webkit.org/show_bug.cgi?id=283980
rdar://140858383

Reviewed by Mike Wyrzykowski.

Introduce helper function to avoid undefined behavior in float to integer
conversions.

* LayoutTests/fast/webgpu/ftoi-expected.txt: Added.
* LayoutTests/fast/webgpu/ftoi.html: Added.
* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::emitNecessaryHelpers):
(WGSL::Metal::FunctionDefinitionWriter::visit):
* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::chooseOverload):
* Source/WebGPU/WGSL/WGSLShaderModule.h:
(WGSL::ShaderModule::usesFtoi const):
(WGSL::ShaderModule::setUsesFtoi):

Canonical link: https://commits.webkit.org/288599@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications