[webkit-changes] [WebKit/WebKit] 4bdbf8: Add test so that bug 285568 can't happen again

Jean-Yves Avenard noreply at github.com
Wed Jan 8 06:07:50 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4bdbf870a50a1150b3ecc5635072c0020f12c2d0
      https://github.com/WebKit/WebKit/commit/4bdbf870a50a1150b3ecc5635072c0020f12c2d0
  Author: Jean-Yves Avenard <jya at apple.com>
  Date:   2025-01-08 (Wed, 08 Jan 2025)

  Changed paths:
    M LayoutTests/media/content/short.wav
    A LayoutTests/media/video-seek-after-end-play-expected.txt
    A LayoutTests/media/video-seek-after-end-play.html
    M LayoutTests/platform/glib/TestExpectations

  Log Message:
  -----------
  Add test so that bug 285568 can't happen again
https://bugs.webkit.org/show_bug.cgi?id=285569
rdar://142517881

Reviewed by Youenn Fablet.

287274 at main broke media playback by not calling MediaPlayer::play() if we
were in the middle of a seek.
With 287274 at main reverted in 288588 at main, we replicate the code pattern used by duolingo to ensure
that such bug can't be re-introduced inadvertently in the future.

* LayoutTests/platform/glib/TestExpectations: ended event isn't fired the 2nd time. webkit.org/b/285595
* LayoutTests/media/content/short.wav: The file was broken. Replace its content with short.mp3 converted to wav using ffmpeg.
* LayoutTests/media/video-seek-after-end-play-expected.txt: Added.
* LayoutTests/media/video-seek-after-end-play.html: Added.

Canonical link: https://commits.webkit.org/288590@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list