[webkit-changes] [WebKit/WebKit] 7d8be0: Range.getClientRects should take surrogate pairs i...

Rob Buis noreply at github.com
Wed Jan 8 01:53:18 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7d8be0b05d9ea1a501cb3b152033ffb86a6046f6
      https://github.com/WebKit/WebKit/commit/7d8be0b05d9ea1a501cb3b152033ffb86a6046f6
  Author: Rob Buis <rbuis at igalia.com>
  Date:   2025-01-08 (Wed, 08 Jan 2025)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/cssom-view/range-client-rects-surrogate-indexing-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/cssom-view/range-client-rects-surrogate-indexing.html
    M Source/WebCore/rendering/RenderObject.cpp

  Log Message:
  -----------
  Range.getClientRects should take surrogate pairs into account
https://bugs.webkit.org/show_bug.cgi?id=285023

Reviewed by Ryosuke Niwa.

Add logic to move to surrogate pair start for Range start and past surrogate pair end for Range end in case the trailing surrogate is indexed [1].

[1] https://drafts.csswg.org/cssom-view-1/#dom-range-getclientrects

* LayoutTests/imported/w3c/web-platform-tests/css/cssom-view/range-client-rects-surrogate-indexing-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/cssom-view/range-client-rects-surrogate-indexing.html: Added.
* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::absoluteRectsForRangeInText):

Canonical link: https://commits.webkit.org/288589@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list