[webkit-changes] [WebKit/WebKit] ecc6a5: Fix flex item positioning in sideways-lr writing mode

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ecc6a5adf55472060270d1dcbd0e1af9d9c72b60
      https://github.com/WebKit/WebKit/commit/ecc6a5adf55472060270d1dcbd0e1af9d9c72b60
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2025-01-07 (Tue, 07 Jan 2025)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/reference/sideways-lr-main-axis-ref.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/sideways-lr-main-axis-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/sideways-lr-main-axis.html
    M Source/WebCore/rendering/RenderFlexibleBox.cpp

  Log Message:
  -----------
  Fix flex item positioning in sideways-lr writing mode
https://bugs.webkit.org/show_bug.cgi?id=285558
rdar://142507498

Reviewed by Alan Baradlay.

Use `WritingMode::isLogicalLeftInlineStart()` instead of `WritingMode::isBidiLTR()` to account for sideways-lr writing mode.

Also add a WPT.

* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/reference/sideways-lr-main-axis-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/sideways-lr-main-axis-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/sideways-lr-main-axis.html: Added.
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::isLeftToRightFlow const):

Canonical link: https://commits.webkit.org/288579@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications