[webkit-changes] [WebKit/WebKit] 99ca7d: Stop using UncheckedKeyHashSet in IPC code

Chris Dumez noreply at github.com
Tue Jan 7 18:50:38 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 99ca7d79d4ea8bb82ef84fe3235a247760d21a2b
      https://github.com/WebKit/WebKit/commit/99ca7d79d4ea8bb82ef84fe3235a247760d21a2b
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2025-01-07 (Tue, 07 Jan 2025)

  Changed paths:
    M Source/WebCore/html/Allowlist.h
    M Source/WebCore/html/PermissionsPolicy.cpp
    M Source/WebCore/loader/CanvasActivityRecord.h
    M Source/WebCore/loader/DocumentLoader.h
    M Source/WebCore/page/ElementTargetingController.cpp
    M Source/WebCore/page/ElementTargetingTypes.h
    M Source/WebCore/page/Quirks.h
    M Source/WebCore/platform/encryptedmedia/CDMRestrictions.h
    M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
    M Source/WebKit/UIProcess/API/APITargetedElementInfo.h
    M Source/WebKit/UIProcess/API/APIWebsitePolicies.h
    M Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.mm
    M Source/WebKit/UIProcess/API/Cocoa/_WKTargetedElementRequest.mm
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm

  Log Message:
  -----------
  Stop using UncheckedKeyHashSet in IPC code
https://bugs.webkit.org/show_bug.cgi?id=285548

Reviewed by Darin Adler.

Stop using UncheckedKeyHashSet in IPC code. We should rely on UncheckedKeyHashSet
as little as possible for security reasons, particularly in IPC code.

* Source/WebCore/html/Allowlist.h:
(WebCore::Allowlist::Allowlist):
(WebCore::Allowlist::matches const):
* Source/WebCore/html/PermissionsPolicy.cpp:
(WebCore::parseAllowlist):
* Source/WebCore/loader/CanvasActivityRecord.h:
* Source/WebCore/loader/DocumentLoader.h:
* Source/WebCore/page/ElementTargetingController.cpp:
(WebCore::collectMediaAndLinkURLsRecursive):
(WebCore::collectMediaAndLinkURLs):
* Source/WebCore/page/ElementTargetingTypes.h:
* Source/WebCore/page/Quirks.h:
* Source/WebCore/platform/encryptedmedia/CDMRestrictions.h:
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
* Source/WebKit/UIProcess/API/APITargetedElementInfo.h:
* Source/WebKit/UIProcess/API/APIWebsitePolicies.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.mm:
(-[WKWebpagePreferences _setContentRuleListsEnabled:exceptions:]):
(-[WKWebpagePreferences _setVisibilityAdjustmentSelectorsIncludingShadowHosts:]):
* Source/WebKit/UIProcess/API/Cocoa/_WKTargetedElementRequest.mm:
(-[_WKTargetedElementRequest initWithSelectors:]):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::adjustVisibilityForTargetedElements):

Canonical link: https://commits.webkit.org/288576@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list