[webkit-changes] [WebKit/WebKit] 946f83: [SVG2] Add support for the 'ch' length type (excep...

[Ahmad Saleem]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 946f8386af931fbf76efce3902c4357670843b69
      https://github.com/WebKit/WebKit/commit/946f8386af931fbf76efce3902c4357670843b69
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2025-01-07 (Tue, 07 Jan 2025)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-ch-expected.txt
    A LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-ch-expected.txt
    A LayoutTests/platform/ios/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-ch-expected.txt
    M Source/WebCore/svg/SVGLengthContext.cpp
    M Source/WebCore/svg/SVGLengthContext.h
    M Source/WebCore/svg/SVGLengthValue.cpp
    M Source/WebCore/svg/SVGLengthValue.h

  Log Message:
  -----------
  [SVG2] Add support for the 'ch' length type (except upright vertical ch)

https://bugs.webkit.org/show_bug.cgi?id=285498
rdar://142463263

Reviewed by Simon Fraser.

This patch aligns WebKit with Gecko / Firefox and Blink / Chromium.

This patch adds support for `ch` (character width) length type for SVGLength,
similar to other length types.

Although, this does not add support for `upright vertical character width`
at least on Apple ports.

* Source/WebCore/svg/SVGLengthContext.cpp:
(WebCore::SVGLengthContext::convertValueToUserUnits const):
(WebCore::SVGLengthContext::convertValueFromUserUnits const):
(WebCore::SVGLengthContext::convertValueFromUserUnitsToCh const):
(WebCore::SVGLengthContext::convertValueFromChToUserUnits const):
* Source/WebCore/svg/SVGLengthContext.h: Removed `value` as argument from functions as well
* Source/WebCore/svg/SVGLengthValue.cpp:
(WebCore::lengthTypeToString):
(WebCore::parseLengthType):
(WebCore::primitiveTypeToLengthType):
(WebCore::lengthTypeToPrimitiveType):
* Source/WebCore/svg/SVGLengthValue.h:
(WebCore::SVGLengthValue::isRelative const):
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-ch-expected.txt: Rebaselined
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-ch-expected.txt:
* LayoutTests/platform/ios/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-ch-expected.txt:

Canonical link: https://commits.webkit.org/288558@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications