[webkit-changes] [WebKit/WebKit] 1bf850: [WebGPU] Error from RenderPassEncoder and ComputeP...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1bf8507af834fc4829b0faf23eaf815b24c537b5
      https://github.com/WebKit/WebKit/commit/1bf8507af834fc4829b0faf23eaf815b24c537b5
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2025-01-07 (Tue, 07 Jan 2025)

  Changed paths:
    M Source/WebGPU/WebGPU/ComputePassEncoder.mm
    M Source/WebGPU/WebGPU/RenderPassEncoder.mm

  Log Message:
  -----------
  [WebGPU] Error from RenderPassEncoder and ComputePassEncoder is not propagating to the CommandEncoder
https://bugs.webkit.org/show_bug.cgi?id=285475
rdar://142440328

Reviewed by Tadeu Zagallo.

Invalid render passes or compute passes were resulting
in 'Encoder state is locked' when calling GPUCommandEncoder.finish()
which is not so helpful. We already require an error message to get
passed, but it was being unused and not reported externally.

Correct this by passing the error message to the corresponding GPUCommandEncoder.

* Source/WebGPU/WebGPU/ComputePassEncoder.mm:
(WebGPU::ComputePassEncoder::ComputePassEncoder):
* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::RenderPassEncoder):

Canonical link: https://commits.webkit.org/288536@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications