[webkit-changes] [WebKit/WebKit] 951a11: Fix missing includes and guards when certain featu...

[Simon Pena]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 951a118e17cd92adc3aa31129af7cd348fac91e9
      https://github.com/WebKit/WebKit/commit/951a118e17cd92adc3aa31129af7cd348fac91e9
  Author: Simon Pena <spena at igalia.com>
  Date:   2025-01-07 (Tue, 07 Jan 2025)

  Changed paths:
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/loader/LinkLoader.cpp
    M Source/WebCore/loader/SubresourceLoader.cpp
    M Source/WebCore/loader/cache/CachedResource.h
    M Source/WebCore/loader/cache/CachedResourceLoader.cpp
    M Source/WebCore/loader/cache/CachedResourceLoader.h
    M Source/WebCore/loader/cache/CachedTextTrack.cpp
    M Source/WebCore/loader/cache/CachedTextTrack.h
    M Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp
    M Source/WebCore/platform/audio/PlatformRawAudioData.cpp
    M Source/WebCore/platform/audio/PlatformRawAudioData.h
    M Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitProtocolHandler.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp
    M Source/WebKit/UIProcess/Automation/libwpe/WebAutomationSessionWPE.cpp
    M Source/WebKit/UIProcess/wpe/WebContextMenuProxyWPE.h
    M Source/WebKit/WebProcess/GPU/ShapeDetection/RemoteBarcodeDetectorProxy.h
    M Source/WebKit/WebProcess/GPU/ShapeDetection/RemoteFaceDetectorProxy.h
    M Source/WebKit/WebProcess/GPU/ShapeDetection/RemoteTextDetectorProxy.h
    M Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp
    M Source/WebKit/WebProcess/WebPage/WebFrame.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.h

  Log Message:
  -----------
  Fix missing includes and guards when certain features are disabled
https://bugs.webkit.org/show_bug.cgi?id=284523

Reviewed by Philippe Normand.

When disabling long-standing features such as VIDEO, WEB_AUDIO, WEB_CODECS
and others, WebKit failed to build as some of the symbols were not
properly guarded, or includes were missing (probably because they were
transitively included otherwise).

* Source/WebCore/dom/Document.cpp:
(WebCore::Document::privateBrowsingStateDidChange): Missing UNUSED_PARAM
when VIDEO is not enabled.
* Source/WebCore/loader/LinkLoader.cpp:
(WebCore::LinkLoader::resourceTypeFromAsAttribute): TextTrackResource
can't be returned with VIDEO not enabled.
(WebCore::createLinkPreloadResourceClient): Skip TextTrackResource with
VIDEO not enabled.
(WebCore::LinkLoader::isSupportedType): ditto.
* Source/WebCore/loader/SubresourceLoader.cpp:
(WebCore::logResourceLoaded): ditto.
* Source/WebCore/loader/cache/CachedResource.h: ditto.
* Source/WebCore/loader/cache/CachedResourceLoader.cpp:
(WebCore::createResource): ditto.
* Source/WebCore/loader/cache/CachedResourceLoader.h: Do not expose
  CachedTextTrack if VIDEO is not enabled.
* Source/WebCore/loader/cache/CachedTextTrack.cpp: Do not expose if
  VIDEO is not enabled.
* Source/WebCore/loader/cache/CachedTextTrack.h: Do not expose if VIDEO
  is not enabled.
* Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp:
(WebCore::PlatformMediaSessionManager::endInterruption): Missing
UNUSED_PARAM when VIDEO is not enabled.
(WebCore::PlatformMediaSessionManager::addSession): Protect
Session-specific members when VIDEO and WEB_AUDIO are not enabled.
(WebCore::PlatformMediaSessionManager::removeSession): ditto.
(WebCore::PlatformMediaSessionManager::sessionWillEndPlayback): ditto.
(WebCore::PlatformMediaSessionManager::setCurrentSession): ditto.
(WebCore::PlatformMediaSessionManager::applicationWillBecomeInactive):
ditto.
(WebCore::PlatformMediaSessionManager::applicationDidBecomeActive):
ditto.
(WebCore::PlatformMediaSessionManager::applicationDidEnterBackground):
ditto.
(WebCore::PlatformMediaSessionManager::applicationWillEnterForeground):
ditto.
(WebCore::PlatformMediaSessionManager::processWillSuspend): ditto.
(WebCore::PlatformMediaSessionManager::processDidResume): ditto.
(WebCore::PlatformMediaSessionManager::processDidReceiveRemoteControlCommand): ditto.
(WebCore::PlatformMediaSessionManager::processSystemWillSleep): ditto.
(WebCore::PlatformMediaSessionManager::processSystemDidWake): ditto.
(WebCore::PlatformMediaSessionManager::stopAllMediaPlaybackForProcess):
ditto.
(WebCore::PlatformMediaSessionManager::suspendAllMediaPlaybackForGroup):
ditto.
(WebCore::PlatformMediaSessionManager::resumeAllMediaPlaybackForGroup):
ditto.
(WebCore::PlatformMediaSessionManager::bestEligibleSessionForRemoteControls): ditto.
(WebCore::PlatformMediaSessionManager::hasActiveNowPlayingSessionInGroup): ditto.
(WebCore::PlatformMediaSessionManager::dumpSessionStates): ditto.
* Source/WebCore/platform/audio/PlatformRawAudioData.cpp: Do not expose
  if WEB_CODECS are not enabled.
* Source/WebCore/platform/audio/PlatformRawAudioData.h: ditto.
* Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp: Missing include.
* Source/WebKit/UIProcess/API/glib/WebKitProtocolHandler.cpp:
(WebKit::WebKitProtocolHandler::handleGPU): Protected renderMediaBuffer
usage with USE(LIBDRM)
* Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp: Guard
  MHTML-related logic better, and fail saving if unavailable.
* Source/WebKit/UIProcess/Automation/libwpe/WebAutomationSessionWPE.cpp:
  Do not expose unused methods when WebDriver's Mouse, Wheel or Touch
interactions are disabled.
* Source/WebKit/UIProcess/wpe/WebContextMenuProxyWPE.h: Do not expose
  when CONTEXT_MENUS is not enabled.
* Source/WebKit/WebProcess/GPU/ShapeDetection/RemoteBarcodeDetectorProxy.h:
  Moved the guard after the type is defined
* Source/WebKit/WebProcess/GPU/ShapeDetection/RemoteFaceDetectorProxy.h:
  ditto.
* Source/WebKit/WebProcess/GPU/ShapeDetection/RemoteTextDetectorProxy.h:
  ditto.
* Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::maximumBufferingTime): Do not expose TextTrackResource if VIDEO
is not enabled.
* Source/WebKit/WebProcess/WebPage/WebFrame.cpp: Missing FrameLoader
  include.
* Source/WebKit/WebProcess/WebPage/WebPage.h: Missing RegistrableDomain
  include.

Canonical link: https://commits.webkit.org/288522@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications