[webkit-changes] [WebKit/WebKit] 7dd857: REGRESSION (288222 at main): Cannot scroll the Santa ...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7dd857b4bcbc8c8f4c18f80eb4ce5a8615684e67
      https://github.com/WebKit/WebKit/commit/7dd857b4bcbc8c8f4c18f80eb4ce5a8615684e67
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2025-01-07 (Tue, 07 Jan 2025)

  Changed paths:
    A LayoutTests/fast/flexbox/percent-height-flex-content-with-space-taking-scrollbar-expected.html
    A LayoutTests/fast/flexbox/percent-height-flex-content-with-space-taking-scrollbar.html
    M Source/WebCore/rendering/RenderFlexibleBox.cpp
    M Source/WebCore/rendering/RenderFlexibleBox.h

  Log Message:
  -----------
  REGRESSION (288222 at main): Cannot scroll the Santa Clara Property Tax Payment website
https://bugs.webkit.org/show_bug.cgi?id=285463
<rdar://142420869>

Reviewed by Antti Koivisto.

The "allow precent resolve" logic introduced in 288222 at main missed the special, after layout adjustment when scrollbar is present.
This change ensures that when we run layout on flex content _after_ flex layout, we still honor the override height value and let precent resolve happen.

* LayoutTests/fast/flexbox/percent-height-flex-content-with-space-taking-scrollbar-expected.html: Added.
* LayoutTests/fast/flexbox/percent-height-flex-content-with-space-taking-scrollbar.html: Added.
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::canUseFlexItemForPercentageResolution):
* Source/WebCore/rendering/RenderFlexibleBox.h:

Canonical link: https://commits.webkit.org/288521@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications