[webkit-changes] [WebKit/WebKit] 8e0a2a: Move groupId handling from MediaStreamTrack to Rea...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8e0a2a00aa01e4eb75ff39050f1a08c0819f1554
      https://github.com/WebKit/WebKit/commit/8e0a2a00aa01e4eb75ff39050f1a08c0819f1554
  Author: Youenn Fablet <youenn at apple.com>
  Date:   2025-01-07 (Tue, 07 Jan 2025)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaDevices-getUserMedia.https-expected.txt
    M Source/WebCore/Modules/mediastream/InputDeviceInfo.cpp
    M Source/WebCore/Modules/mediastream/MediaDevices.cpp
    M Source/WebCore/Modules/mediastream/MediaDevices.h
    M Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp
    M Source/WebCore/Modules/mediastream/MediaStreamTrack.h
    M Source/WebCore/Modules/mediastream/MediaTrackCapabilities.cpp
    M Source/WebCore/Modules/mediastream/MediaTrackCapabilities.h
    M Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp
    M Source/WebCore/platform/mediastream/RealtimeMediaSource.h
    M Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm
    M Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp
    M Source/WebCore/platform/mock/MockRealtimeAudioSource.cpp
    M Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp

  Log Message:
  -----------
  Move groupId handling from MediaStreamTrack to RealtimeMediaSource
rdar://142420841
https://bugs.webkit.org/show_bug.cgi?id=285438

Reviewed by Eric Carlson.

Previoulsy, groupId was computed in MediaStreamTrack as its hash is scoped by Document.
We are now handling groupId within RealtimeMediaSource and provide the document scoped hash when creating the RealtimeMediaSource.
We remove the current handling (shared between MediaDevices and MediaStreamTrack).

We update the capture sources to provide groupId values, including the mocks.

Covered by existing tests.

* LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaDevices-getUserMedia.https-expected.txt:
* Source/WebCore/Modules/mediastream/InputDeviceInfo.cpp:
(WebCore::InputDeviceInfo::getCapabilities const):
* Source/WebCore/Modules/mediastream/MediaDevices.cpp:
(WebCore::MediaDevices::MediaDevices):
(WebCore::MediaDevices::exposeDevices):
(WebCore::MediaDevices::hashedGroupId): Deleted.
* Source/WebCore/Modules/mediastream/MediaDevices.h:
* Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::MediaStreamTrack):
(WebCore::MediaStreamTrack::getSettings const):
(WebCore::MediaStreamTrack::getCapabilities const):
* Source/WebCore/Modules/mediastream/MediaStreamTrack.h:
* Source/WebCore/Modules/mediastream/MediaTrackCapabilities.cpp:
(WebCore::toMediaTrackCapabilities):
* Source/WebCore/Modules/mediastream/MediaTrackCapabilities.h:
* Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp:
(WebCore::m_device):
(WebCore::RealtimeMediaSource::setPersistentId):
(WebCore::RealtimeMediaSource::initializeIds):
(WebCore::RealtimeMediaSource::~RealtimeMediaSource): Deleted.
(WebCore::RealtimeMediaSource::initializePersistentId): Deleted.
* Source/WebCore/platform/mediastream/RealtimeMediaSource.h:
(WebCore::RealtimeMediaSource::hashedGroupId const):
* Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoCaptureSource::settings):
(WebCore::AVVideoCaptureSource::capabilities):
* Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp:
(WebCore::CoreAudioCaptureSource::capabilities):
(WebCore::CoreAudioCaptureSource::settings):
* Source/WebCore/platform/mock/MockRealtimeAudioSource.cpp:
(WebCore::MockRealtimeAudioSource::settings):
(WebCore::MockRealtimeAudioSource::capabilities):
* Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp:
(WebCore::MockRealtimeVideoSource::capabilities):
(WebCore::MockRealtimeVideoSource::settings):

Canonical link: https://commits.webkit.org/288520@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications