[webkit-changes] [WebKit/WebKit] f9c75c: Sync `input` specific unicode-bidi rendering from ...

[Ahmad Saleem]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f9c75ce4940750e1d205141765f84f50241e97aa
      https://github.com/WebKit/WebKit/commit/f9c75ce4940750e1d205141765f84f50241e97aa
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2025-01-07 (Tue, 07 Jan 2025)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/html/rendering/bidi-rendering/unicode-bidi-ua-rules-expected.txt
    M Source/WebCore/css/html.css
    M Source/WebCore/html/HTMLElement.cpp

  Log Message:
  -----------
  Sync `input` specific unicode-bidi rendering from Web Specification

https://bugs.webkit.org/show_bug.cgi?id=285252
rdar://142191490

Reviewed by Aditya Keerthi.

This patch aligns WebKit with Web Specification [1]:

[1] https://html.spec.whatwg.org/multipage/rendering.html#bidi-rendering

This patch implements `input` specific rules for directionality being `auto`
and move `textarea` and `pre` rules in UA stylesheet. The rationale is that `is:`
can be lead to performance concern, so did the change in C++, it also
matches Blink / Chromium.

Despite aligning with specification, there is still ambiguity on how to deal with
`password` and `text` input types for which following issue is raised [2].

[2] https://github.com/whatwg/html/issues/10896

* Source/WebCore/css/html.css:
(textarea[dir=auto i], pre[dir=auto i]):
* Source/WebCore/html/HTMLElement.cpp:
(WebCore::unicodeBidiAttributeForDirAuto):
* LayoutTests/imported/w3c/web-platform-tests/html/rendering/bidi-rendering/unicode-bidi-ua-rules-expected.txt: Rebaselined
(WebCore::HTMLElement::collectPresentationalHintsForAttribute):

Canonical link: https://commits.webkit.org/288511@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications