[webkit-changes] [WebKit/WebKit] a345bb: Remove some unused page color change SPI

Alex Christensen noreply at github.com
Mon Jan 6 17:17:56 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a345bb5b793acac657978e55da73977272063e52
      https://github.com/WebKit/WebKit/commit/a345bb5b793acac657978e55da73977272063e52
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2025-01-06 (Mon, 06 Jan 2025)

  Changed paths:
    M Source/WebKit/UIProcess/API/Cocoa/WKViewPrivate.h
    M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h
    M Source/WebKit/UIProcess/API/mac/WKView.mm
    M Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.h
    M Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.mm
    M Source/WebKit/UIProcess/PageClient.h
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.h

  Log Message:
  -----------
  Remove some unused page color change SPI
https://bugs.webkit.org/show_bug.cgi?id=285470
rdar://76662644

Reviewed by Simon Fraser.

These haven't been used for several years.  They have been replaced by API
that has been adopted by Safari.

* Source/WebKit/UIProcess/API/Cocoa/WKViewPrivate.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _themeColor]): Deleted.
(-[WKWebView _pageExtendedBackgroundColor]): Deleted.
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:
* Source/WebKit/UIProcess/API/mac/WKView.mm:
(-[WKView _pageExtendedBackgroundColor]): Deleted.
* Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.h:
* Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.mm:
(WebKit::PageClientImplCocoa::themeColorWillChange):
(WebKit::PageClientImplCocoa::themeColorDidChange):
(WebKit::PageClientImplCocoa::pageExtendedBackgroundColorWillChange): Deleted.
(WebKit::PageClientImplCocoa::pageExtendedBackgroundColorDidChange): Deleted.
* Source/WebKit/UIProcess/PageClient.h:
(WebKit::PageClient::underPageBackgroundColorDidChange):
(WebKit::PageClient::pageExtendedBackgroundColorWillChange): Deleted.
(WebKit::PageClient::pageExtendedBackgroundColorDidChange): Deleted.
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::pageExtendedBackgroundColorDidChange):
* Source/WebKit/UIProcess/WebPageProxy.h:

Canonical link: https://commits.webkit.org/288497@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list