[webkit-changes] [WebKit/WebKit] e6b911: [Site isolation] PDF links are not recorded as ann...

[Said Abou-Hallawa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e6b91144cce5990745fafe61f9d923398cedef8c
      https://github.com/WebKit/WebKit/commit/e6b91144cce5990745fafe61f9d923398cedef8c
  Author: Said Abou-Hallawa <said at apple.com>
  Date:   2025-01-06 (Mon, 06 Jan 2025)

  Changed paths:
    M Source/WebCore/platform/graphics/displaylists/DisplayListItem.h
    M Source/WebCore/platform/graphics/displaylists/DisplayListItems.cpp
    M Source/WebCore/platform/graphics/displaylists/DisplayListItems.h
    M Source/WebCore/platform/graphics/displaylists/DisplayListRecorderImpl.cpp
    M Source/WebCore/platform/graphics/displaylists/DisplayListRecorderImpl.h
    M Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.cpp
    M Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.h
    M Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.messages.in
    M Source/WebKit/Shared/DisplayListArgumentCoders.serialization.in
    M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
    M Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp
    M Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.h

  Log Message:
  -----------
  [Site isolation] PDF links are not recorded as annotations if site-isolation is enabled
https://bugs.webkit.org/show_bug.cgi?id=285412#
rdar://142399120

Reviewed by Tim Horton.

Is site isolation is enabled, snapshotting the PDFPage has to happen in GPUProcess.
The WebPage links are stored as link annotations in the PDFPage. This happens
through RenderObject::addPDFURLRect() which calls GraphicsContext::setURLForRect().
RecorderImpl and RemoteDisplayListRecorderProxy need to implement setURLForRect.

* Source/WebCore/platform/graphics/displaylists/DisplayListItem.h:
* Source/WebCore/platform/graphics/displaylists/DisplayListItems.cpp:
(WebCore::DisplayList::SetURLForRect::apply const):
(WebCore::DisplayList::SetURLForRect::dump const):
* Source/WebCore/platform/graphics/displaylists/DisplayListItems.h:
(WebCore::DisplayList::SetURLForRect::SetURLForRect):
(WebCore::DisplayList::SetURLForRect::link const):
(WebCore::DisplayList::SetURLForRect::destRect const):
* Source/WebCore/platform/graphics/displaylists/DisplayListRecorderImpl.cpp:
(WebCore::DisplayList::RecorderImpl::setURLForRect):
* Source/WebCore/platform/graphics/displaylists/DisplayListRecorderImpl.h:
* Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.cpp:
(WebKit::RemoteDisplayListRecorder::setURLForRect):
* Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.h:
* Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.messages.in:
* Source/WebKit/Shared/DisplayListArgumentCoders.serialization.in:
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
* Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp:
(WebKit::RemoteDisplayListRecorderProxy::setURLForRect):
* Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.h:

Canonical link: https://commits.webkit.org/288470@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications