[webkit-changes] [WebKit/WebKit] 1e3a17: ASSERTION FAILED: !input->userAgentShadowRoot() wh...

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1e3a17caec13822eb8f0cc09a21038b31ba233b2
      https://github.com/WebKit/WebKit/commit/1e3a17caec13822eb8f0cc09a21038b31ba233b2
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2025-01-06 (Mon, 06 Jan 2025)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/input-type-checkbox-switch.tentative.window-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/input-type-checkbox-switch.tentative.window.js
    M Source/WebCore/html/CheckboxInputType.cpp
    M Source/WebCore/html/HTMLInputElement.cpp

  Log Message:
  -----------
  ASSERTION FAILED: !input->userAgentShadowRoot() when cloning a switch input
https://bugs.webkit.org/show_bug.cgi?id=285338

Reviewed by Ryosuke Niwa.

No longer initialize a user agent shadow root when a switch attribute
is set through the parser or cloning as this will be taken care of
later.

Additionally, add more ScriptDisallowedScope::EventAllowedScope
annotations inside <input type=checkbox switch> user agent shadow root
creation as otherwise we'd run into asserts there as well.

* LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/input-type-checkbox-switch.tentative.window-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/input-type-checkbox-switch.tentative.window.js:
* Source/WebCore/html/CheckboxInputType.cpp:
(WebCore::CheckboxInputType::createShadowSubtree):
* Source/WebCore/html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::attributeChanged):

Canonical link: https://commits.webkit.org/288458@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications