[webkit-changes] [WebKit/WebKit] c0e878: Make CSSPageRule derive from CSSGroupingRule

Ahmad Saleem noreply at github.com
Sun Jan 5 06:16:18 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c0e87804c1fd0d314e0aca4eb70612c930628d62
      https://github.com/WebKit/WebKit/commit/c0e87804c1fd0d314e0aca4eb70612c930628d62
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2025-01-05 (Sun, 05 Jan 2025)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/cssom/idlharness-expected.txt
    M Source/WebCore/css/CSSPageRule.cpp
    M Source/WebCore/css/CSSPageRule.h
    M Source/WebCore/css/CSSPageRule.idl
    M Source/WebCore/css/StyleRule.cpp
    M Source/WebCore/css/StyleRule.h

  Log Message:
  -----------
  Make CSSPageRule derive from CSSGroupingRule
https://bugs.webkit.org/show_bug.cgi?id=216940
rdar://69847560

Reviewed by Darin Adler.

This page aligns WebKit with Web Specification [1]:

[1] https://drafts.csswg.org/cssom/#csspagerule

This is to derive `CSSPageRule` from `CSSGroupingRule` instead of
`CSSRule` as it does currently.

* Source/WebCore/css/CSSPageRule.cpp:
(WebCore::CSSPageRule::CSSPageRule):
* Source/WebCore/css/CSSPageRule.h:
* Source/WebCore/css/CSSPageRule.idl:
* Source/WebCore/css/StyleRule.cpp: Bit rearrangement near Grouping
(WebCore::StyleRulePage::StyleRulePage):
(WebCore::m_selectorList):
(WebCore::StyleRulePage::create):
(WebCore::StyleRulePage::mutableProperties):
* Source/WebCore/css/StyleRule.h: Bit rearrangement near Grouping
* LayoutTests/imported/w3c/web-platform-tests/css/cssom/idlharness-expected.txt: Rebaselined

Canonical link: https://commits.webkit.org/288443@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list