[webkit-changes] [WebKit/WebKit] bd0da2: Update message endpoint annotation using MediaPlay...

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bd0da29863b5d4256a2439390ed2e89fbf3febac
      https://github.com/WebKit/WebKit/commit/bd0da29863b5d4256a2439390ed2e89fbf3febac
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2025-01-04 (Sat, 04 Jan 2025)

  Changed paths:
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebKit/GPUProcess/GPUConnectionToWebProcess.messages.in
    M Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.messages.in
    M Source/WebKit/GPUProcess/media/RemoteAudioSessionProxy.messages.in
    M Source/WebKit/GPUProcess/media/RemoteMediaEngineConfigurationFactoryProxy.messages.in
    M Source/WebKit/GPUProcess/media/RemoteMediaPlayerManagerProxy.messages.in
    M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.messages.in
    M Source/WebKit/GPUProcess/media/RemoteRemoteCommandListenerProxy.messages.in
    M Source/WebKit/GPUProcess/media/ios/RemoteMediaSessionHelperProxy.messages.in
    M Source/WebKit/GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererInternalUnitManager.messages.in
    M Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.messages.in
    M Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.messages.in
    M Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.messages.in
    M Source/WebKit/UIProcess/Media/AudioSessionRoutingArbitratorProxy.messages.in
    M Source/WebKit/UIProcess/WebPageProxy.messages.in

  Log Message:
  -----------
  Update message endpoint annotation using MediaPlaybackEnabled
https://bugs.webkit.org/show_bug.cgi?id=285358
rdar://142329275

Reviewed by Youenn Fablet.

For some message endpoints that are guarded with MediaPlaybackEnabled flag, the annotation is incorrect as web process
can still send them when MediaPlaybackEnabled is false in our current implementation (web process does not check the
flag before sending the messages). To fix this, update them to use ExceptionForEnabledBy (if the message can be sent in
all cases) or EnabledBy=UseGPUProcessForMediaEnabled (if the message can only be sent when GPU process is used for
media) instead.

This patch also updates annotation for some messages that will be sent only when both MediaPlaybackEnabled and
UseGPUProcessForMediaEnabled are true.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebKit/GPUProcess/GPUConnectionToWebProcess.messages.in:
* Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.messages.in:
* Source/WebKit/GPUProcess/media/RemoteAudioSessionProxy.messages.in:
* Source/WebKit/GPUProcess/media/RemoteMediaEngineConfigurationFactoryProxy.messages.in:
* Source/WebKit/GPUProcess/media/RemoteMediaPlayerManagerProxy.messages.in:
* Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.messages.in:
* Source/WebKit/GPUProcess/media/RemoteRemoteCommandListenerProxy.messages.in:
* Source/WebKit/GPUProcess/media/ios/RemoteMediaSessionHelperProxy.messages.in:
* Source/WebKit/GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererInternalUnitManager.messages.in:
* Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.messages.in:
* Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.messages.in:
* Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.messages.in:
* Source/WebKit/UIProcess/Media/AudioSessionRoutingArbitratorProxy.messages.in:
* Source/WebKit/UIProcess/WebPageProxy.messages.in:

Canonical link: https://commits.webkit.org/288438@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications