[webkit-changes] [WebKit/WebKit] 44116c: Make the flag for ResourceMonitor testable.

[Basuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 44116c35ed45b3f932ee86980248faa7a421042d
      https://github.com/WebKit/WebKit/commit/44116c35ed45b3f932ee86980248faa7a421042d
  Author: Basuke Suzuki <basuke at apple.com>
  Date:   2025-01-03 (Fri, 03 Jan 2025)

  Changed paths:
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebCore/loader/ResourceMonitor.cpp
    M Source/WebCore/loader/ResourceMonitor.h
    M Tools/WebKitTestRunner/TestOptions.cpp

  Log Message:
  -----------
  Make the flag for ResourceMonitor testable.
https://bugs.webkit.org/show_bug.cgi?id=285366
rdar://142331749

Reviewed by Chris Dumez and Sihui Liu.

Make the flag `IFrameResourceMonitoringEnabled` to manage ResourceMonitor feature from `unstable`
to `internal` and enable it in test infrastructure by adding it TestOptions::defaults.

When enabling it, the bug was found that the frame could be disposed before ResourceMonitor is
disposed. Fix the bug by making `m_frame` as `WeakPtr` and check the validity before use.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/loader/ResourceMonitor.cpp:
(WebCore::ResourceMonitor::setDocumentURL):
(WebCore::ResourceMonitor::didReceiveResponse):
(WebCore::ResourceMonitor::checkNetworkUsageExcessIfNecessary):
(WebCore::ResourceMonitor::parentResourceMonitorIfExists const):
(WebCore::ResourceMonitor::protectedFrame const): Deleted.
* Source/WebCore/loader/ResourceMonitor.h:
* Tools/WebKitTestRunner/TestOptions.cpp:
(WTR::TestOptions::defaults):

Canonical link: https://commits.webkit.org/288429@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications