[webkit-changes] [WebKit/WebKit] 0ee211: Regression(288156 at main): http/tests/security/conte...

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0ee21124e6f2f761479cf2a5e3d9b09ae014e61e
      https://github.com/WebKit/WebKit/commit/0ee21124e6f2f761479cf2a5e3d9b09ae014e61e
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2025-01-03 (Fri, 03 Jan 2025)

  Changed paths:
    M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp
    M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in
    M Source/WebKit/NetworkProcess/NetworkSocketChannel.cpp
    M Source/WebKit/NetworkProcess/NetworkSocketChannel.h
    M Source/WebKit/NetworkProcess/NetworkSocketChannel.messages.in

  Log Message:
  -----------
  Regression(288156 at main): http/tests/security/contentSecurityPolicy/connect-src-star-websocket-allowed.html is flakily crashing
https://bugs.webkit.org/show_bug.cgi?id=285348
rdar://142320806

Reviewed by Charlie Wolfe.

According to crash log on bots, network process kills web process for sending NetworkSocketChannel message when
WebSocketEnabled is false. However, WebSocketEnabled should always be true during test run, so there could be other
issues in implementation. To avoid slowing down bots during investigation, revert 288156 at main. Also, to investigate the
root cause, add debug assertion and loggings to help understand how WebSocketEnabled becomes false.

* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::m_ipcTester):
(WebKit::NetworkConnectionToWebProcess::dispatchMessage):
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in:
* Source/WebKit/NetworkProcess/NetworkSocketChannel.cpp:
(WebKit::NetworkSocketChannel::sharedPreferencesForWebProcess): Deleted.
* Source/WebKit/NetworkProcess/NetworkSocketChannel.h:
* Source/WebKit/NetworkProcess/NetworkSocketChannel.messages.in:

Canonical link: https://commits.webkit.org/288420@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications