[webkit-changes] [WebKit/WebKit] 5b926e: [WebGPUSwift] Swift Implementation of beginCompute...
nmahendru
noreply at github.com
Fri Jan 3 14:03:23 PST 2025
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5b926e148a538c01693807f22e001b679981504e
https://github.com/WebKit/WebKit/commit/5b926e148a538c01693807f22e001b679981504e
Author: Nitin Mahendru <nitinmahendru at apple.com>
Date: 2025-01-03 (Fri, 03 Jan 2025)
Changed paths:
M Source/WebGPU/WebGPU/CommandEncoder.h
M Source/WebGPU/WebGPU/CommandEncoder.mm
M Source/WebGPU/WebGPU/CommandEncoder.swift
M Source/WebGPU/WebGPU/ComputePassEncoder.h
M Source/WebGPU/WebGPU/Internal/WebGPUSwiftInternal.h
Log Message:
-----------
[WebGPUSwift] Swift Implementation of beginComputePass
rdar://141069436
https://bugs.webkit.org/show_bug.cgi?id=284195
Reviewed by Mike Wyrzykowski.
It's 1-to-1 replacement.
In some of the failure cases I have added extra returns for
returning an invalid ComputePassEncoder. They only show up for cases
where swift maps the Cpp types as optionals.
* Source/WebGPU/WebGPU/CommandEncoder.h:
* Source/WebGPU/WebGPU/CommandEncoder.mm:
* Source/WebGPU/WebGPU/CommandEncoder.swift:
(CommandEncoder_beginComputePass_thunk(_:descriptor:)):
(WebGPU.beginComputePass(_:)):
* Source/WebGPU/WebGPU/ComputePassEncoder.h:
(refComputePassEncoder):
(derefComputePassEncoder):
* Source/WebGPU/WebGPU/Internal/WebGPUSwiftInternal.h:
Canonical link: https://commits.webkit.org/288419@main
To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications
More information about the webkit-changes
mailing list