[webkit-changes] [WebKit/WebKit] f0baf5: [view-transitions] animation-name set from user ag...

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f0baf504e518ad2af424e9ea20c6fbf0defebdfc
      https://github.com/WebKit/WebKit/commit/f0baf504e518ad2af424e9ea20c6fbf0defebdfc
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2025-01-03 (Fri, 03 Jan 2025)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/dynamic-stylesheet-animations-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/dynamic-stylesheet-animations.html
    M Source/WebCore/dom/ViewTransition.cpp

  Log Message:
  -----------
  [view-transitions] animation-name set from user agent dynamic stylesheet has extra quotes
https://bugs.webkit.org/show_bug.cgi?id=285295
rdar://142298840

Reviewed by Darin Adler.

- Use `createCustomIdent` to avoid showing quotes around animation names.
- Stop setting animation names on pseudo-elements when the pseudo-element is not generated (not really user observable, aside from getComputedStyle)
- Add a WPT to test all of these

Spec: https://drafts.csswg.org/css-view-transitions/#setup-transition-pseudo-elements-algorithm

* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/dynamic-stylesheet-animations-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/dynamic-stylesheet-animations.html: Added.
* Source/WebCore/dom/ViewTransition.cpp:
(WebCore::ViewTransition::setupDynamicStyleSheet):

Canonical link: https://commits.webkit.org/288417@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications