[webkit-changes] [WebKit/WebKit] 24a214: Use more const and strong references on stack in W...

Alex Christensen noreply at github.com
Fri Jan 3 11:00:02 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 24a214b27c99a122f194c92c8a01b82964d4de66
      https://github.com/WebKit/WebKit/commit/24a214b27c99a122f194c92c8a01b82964d4de66
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2025-01-03 (Fri, 03 Jan 2025)

  Changed paths:
    M Source/WebKit/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
    M Source/WebKit/WebProcess/Network/WebResourceLoader.cpp
    M Source/WebKit/WebProcess/Network/WebResourceLoader.h

  Log Message:
  -----------
  Use more const and strong references on stack in WebResourceLoader
https://bugs.webkit.org/show_bug.cgi?id=285321
rdar://142290548

Reviewed by Tim Nguyen.

Keeping a RefPtr on the stack instead of just a raw pointer will ensure
the Page or Frame is not destroyed before the function returns.

* Source/WebKit/WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::mainFrameMainResource const):
(WebKit::WebResourceLoader::willSendRequest):
(WebKit::WebResourceLoader::didReceiveResource):
* Source/WebKit/WebProcess/Network/WebResourceLoader.h:

Canonical link: https://commits.webkit.org/288410@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list