[webkit-changes] [WebKit/WebKit] ba5d1a: Child extension frames randomly treated as the mai...

Charlie Wolfe noreply at github.com
Fri Jan 3 09:54:14 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ba5d1ac1a8734b47080a6606516626fde2e98080
      https://github.com/WebKit/WebKit/commit/ba5d1ac1a8734b47080a6606516626fde2e98080
  Author: Charlie Wolfe <charliew at apple.com>
  Date:   2025-01-03 (Fri, 03 Jan 2025)

  Changed paths:
    M Source/WebKit/Shared/Extensions/WebExtensionFrameIdentifier.cpp

  Log Message:
  -----------
  Child extension frames randomly treated as the main frame
https://bugs.webkit.org/show_bug.cgi?id=285328
rdar://142299531

Reviewed by Timothy Hatcher.

WebExtensionFrameIdentifier uses the ObjectIdentifier on FrameIdentifier for child frames but creates a
new unique identifier for the main frame. A child frame may have an identifier that collides with the
main frame’s actual ObjectIdentifier, so they should never be matched.

* Source/WebKit/Shared/Extensions/WebExtensionFrameIdentifier.cpp:
(WebKit::matchesFrame):

Canonical link: https://commits.webkit.org/288405@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list