[webkit-changes] [WebKit/WebKit] 802b4a: Cookie partitioning quirk doesn't handle redirects

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 802b4aa786a0bbf9712f358073e2b030b7c39a84
      https://github.com/WebKit/WebKit/commit/802b4aa786a0bbf9712f358073e2b030b7c39a84
  Author: Matthew Finkel <m_finkel at apple.com>
  Date:   2025-01-03 (Fri, 03 Jan 2025)

  Changed paths:
    M Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm
    M Source/WebKit/NetworkProcess/cocoa/NetworkTaskCocoa.h
    M Source/WebKit/NetworkProcess/cocoa/NetworkTaskCocoa.mm

  Log Message:
  -----------
  Cookie partitioning quirk doesn't handle redirects
https://bugs.webkit.org/show_bug.cgi?id=285307
rdar://142278344

Reviewed by Alex Christensen.

The assertion that the callback block is only set once for a task was not
correct. This patch adjusts the logic so it allows for redirects. The original
patch also reversed the first/third party functions, so I'm fixing that here,
too.

* Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
* Source/WebKit/NetworkProcess/cocoa/NetworkTaskCocoa.h:
* Source/WebKit/NetworkProcess/cocoa/NetworkTaskCocoa.mm:
(WebKit::NetworkTaskCocoa::setCookieTransformForThirdPartyRequest):
(WebKit::NetworkTaskCocoa::setCookieTransformForFirstPartyRequest):
(WebKit::NetworkTaskCocoa::setCookieTransform):
(WebKit::NetworkTaskCocoa::willPerformHTTPRedirection):

Canonical link: https://commits.webkit.org/288399@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications