[webkit-changes] [WebKit/WebKit] 7ec5fd: Convert coordinates properly for floats in writing...

fantasai noreply at github.com
Thu Jan 2 14:52:41 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7ec5fd966ea9fb4de524645666d6dbafcbaa0cea
      https://github.com/WebKit/WebKit/commit/7ec5fd966ea9fb4de524645666d6dbafcbaa0cea
  Author: Elika Etemad <fantasai.bugs at inkedblade.net>
  Date:   2025-01-02 (Thu, 02 Jan 2025)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/sideways-inline-003-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/sideways-inline-003-ref.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/sideways-inline-003.html
    M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp

  Log Message:
  -----------
  Convert coordinates properly for floats in writing-mode: sideways-lr
https://bugs.webkit.org/show_bug.cgi?id=285276
rdar://142227732

Reviewed by Alan Baradlay.

Updates preparePlacedFloats to convert external floats to logical coordinates,
and toMarginAndBorderBoxVisualRect to convert logical coordinates out to
RenderBox coordinates in sideways-lr mode.

* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/sideways-inline-003-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/sideways-inline-003-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/sideways-inline-003.html: Added.
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::toMarginAndBorderBoxVisualRect):
(WebCore::LayoutIntegration::LineLayout::updateRenderTreePositions):
(WebCore::LayoutIntegration::LineLayout::preparePlacedFloats):

Canonical link: https://commits.webkit.org/288382@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list