[webkit-changes] [WebKit/WebKit] 319ce4: Correctly orient shadow offsets in sideways-lr modes

[fantasai]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 319ce4ee332042cc4b4a7ca5677fc7d338f87d41
      https://github.com/WebKit/WebKit/commit/319ce4ee332042cc4b4a7ca5677fc7d338f87d41
  Author: Elika Etemad <fantasai.bugs at inkedblade.net>
  Date:   2025-01-02 (Thu, 02 Jan 2025)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/text-shadow-sideways-001-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/text-shadow-sideways-001-ref.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/text-shadow-sideways-001.html
    M Source/WebCore/rendering/TextBoxPainter.cpp
    M Source/WebCore/rendering/TextBoxPainter.h
    M Source/WebCore/rendering/TextDecorationPainter.cpp
    M Source/WebCore/rendering/TextPainter.cpp
    M Source/WebCore/rendering/TextPainter.h

  Log Message:
  -----------
  Correctly orient shadow offsets in sideways-lr modes
https://bugs.webkit.org/show_bug.cgi?id=285221
rdar://problem/142128648

Reviewed by Alan Baradlay.

Teaches the text and text decoration shadow offset adjustment code
to handle counter-clockwise rotation for sideways-lr.

* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/text-shadow-sideways-001-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/text-shadow-sideways-001-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/text-shadow-sideways-001.html: Added.
* Source/WebCore/rendering/TextBoxPainter.cpp:
(WebCore::TextBoxPainter::paintForeground):
* Source/WebCore/rendering/TextBoxPainter.h:
(WebCore::TextBoxPainter::rotateShadowOffset):
* Source/WebCore/rendering/TextDecorationPainter.cpp:
(WebCore::convertShadowOffset):
(WebCore::TextDecorationPainter::paintBackgroundDecorations):
* Source/WebCore/rendering/TextPainter.cpp:
(WebCore::ShadowApplier::ShadowApplier):
(WebCore::TextPainter::TextPainter):
(WebCore::TextPainter::paintTextWithShadows):
* Source/WebCore/rendering/TextPainter.h:
(WebCore::TextPainter::setShadowColorFilter):
(WebCore::TextPainter::setIsHorizontal): Deleted.

Canonical link: https://commits.webkit.org/288377@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications