[webkit-changes] [WebKit/WebKit] e63f32: AX: Remove redundant properties AXProperty::{ARIAT...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e63f322ad08cc0655764be295df3a6ceab91367c
      https://github.com/WebKit/WebKit/commit/e63f322ad08cc0655764be295df3a6ceab91367c
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2025-01-02 (Thu, 02 Jan 2025)

  Changed paths:
    M Source/WebCore/accessibility/AXCoreObject.cpp
    M Source/WebCore/accessibility/AXCoreObject.h
    M Source/WebCore/accessibility/AXLogger.cpp
    M Source/WebCore/accessibility/AccessibilityObject.cpp
    M Source/WebCore/accessibility/AccessibilityObject.h
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h

  Log Message:
  -----------
  AX: Remove redundant properties AXProperty::{ARIATreeRows, HeaderContainer}
https://bugs.webkit.org/show_bug.cgi?id=285156
rdar://142043300

Reviewed by Chris Fleizach.

We can compute this property on-demand with information we have already cached off the main-thread. This change allows
us to do less up-front work when creating each object, guarantees these properties can never get stale (because they don't exist),
and saves memory.

* Source/WebCore/accessibility/AXCoreObject.cpp:
(WebCore::AXCoreObject::ariaTreeRows):
* Source/WebCore/accessibility/AXCoreObject.h:
* Source/WebCore/accessibility/AXLogger.cpp:
(WebCore::operator<<):
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::ariaTreeRows): Deleted.
* Source/WebCore/accessibility/AccessibilityObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::initializeProperties):
(WebCore::AXIsolatedObject::headerContainer):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::updateNodeProperties):
(WebCore::AXIsolatedTree::updateDependentProperties):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:

Canonical link: https://commits.webkit.org/288373@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications