[webkit-changes] [WebKit/WebKit] 3787fc: [Cleanup] overridingContainingBlock* functions are...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3787fcf991a240ae5ede3e14bbd5f5fe2a3262f0
      https://github.com/WebKit/WebKit/commit/3787fcf991a240ae5ede3e14bbd5f5fe2a3262f0
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2025-01-01 (Wed, 01 Jan 2025)

  Changed paths:
    M Source/WebCore/rendering/GridLayoutFunctions.cpp
    M Source/WebCore/rendering/GridLayoutFunctions.h
    M Source/WebCore/rendering/GridMasonryLayout.cpp
    M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp
    M Source/WebCore/rendering/RenderBlock.cpp
    M Source/WebCore/rendering/RenderBox.cpp
    M Source/WebCore/rendering/RenderBox.h
    M Source/WebCore/rendering/RenderBoxModelObject.cpp
    M Source/WebCore/rendering/RenderGrid.cpp

  Log Message:
  -----------
  [Cleanup] overridingContainingBlock* functions are specific to grid layout
https://bugs.webkit.org/show_bug.cgi?id=285253

Reviewed by Antti Koivisto.

Grid item's (and positioned boxes) containing block is not the grid container, but the grid area, for which we don't have a renderer. Let's rename these overriding functions to gridArea* as this functionality is specific to grid layout.

* Source/WebCore/rendering/GridLayoutFunctions.cpp:
(WebCore::GridLayoutFunctions::overridingContainingBlockContentSizeForGridItem):
* Source/WebCore/rendering/GridLayoutFunctions.h:
* Source/WebCore/rendering/GridMasonryLayout.cpp:
(WebCore::GridMasonryLayout::setItemGridAxisContainingBlockToGridArea):
* Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::setOverridingContainingBlockContentSizeForGridItem):
* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::RenderBlock::insertPositionedObject):
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange):
(WebCore::RenderBox::gridItemContainingBlockContentWidth const):
(WebCore::RenderBox::gridItemContainingBlockContentHeight const):
(WebCore::RenderBox::gridItemContainingBlockContentLogicalWidth const):
(WebCore::RenderBox::gridItemContainingBlockContentLogicalHeight const):
(WebCore::RenderBox::setGridItemContainingBlockContentLogicalWidth):
(WebCore::RenderBox::setGridItemContainingBlockContentLogicalHeight):
(WebCore::RenderBox::clearGridItemContainingBlockContentSize):
(WebCore::RenderBox::clearGridItemContainingBlockContentLogicalHeight):
(WebCore::RenderBox::containingBlockLogicalWidthForContent const):
(WebCore::RenderBox::containingBlockLogicalHeightForContent const):
(WebCore::RenderBox::perpendicularContainingBlockLogicalHeight const):
(WebCore::RenderBox::computePercentageLogicalHeight const):
(WebCore::RenderBox::replacedMinMaxLogicalHeightComputesAsNone const):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing const):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned const):
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned const):
(WebCore::RenderBox::hasAutoHeightOrContainingBlockWithAutoHeight const):
(WebCore::RenderBox::overridingContainingBlockContentWidth const): Deleted.
(WebCore::RenderBox::overridingContainingBlockContentHeight const): Deleted.
(WebCore::RenderBox::overridingContainingBlockContentLogicalWidth const): Deleted.
(WebCore::RenderBox::overridingContainingBlockContentLogicalHeight const): Deleted.
(WebCore::RenderBox::setOverridingContainingBlockContentLogicalWidth): Deleted.
(WebCore::RenderBox::setOverridingContainingBlockContentLogicalHeight): Deleted.
(WebCore::RenderBox::clearOverridingContainingBlockContentSize): Deleted.
(WebCore::RenderBox::clearOverridingContainingBlockContentLogicalHeight): Deleted.
* Source/WebCore/rendering/RenderBox.h:
* Source/WebCore/rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::relativePositionOffset const):
* Source/WebCore/rendering/RenderGrid.cpp:
(WebCore::RenderGrid::placeItemsOnGrid):
(WebCore::overrideSizeChanged):
(WebCore::RenderGrid::updateGridAreaLogicalSize const):
(WebCore::RenderGrid::layoutPositionedObject):
(WebCore::RenderGrid::applyStretchAlignmentToGridItemIfNeeded):
(WebCore::RenderGrid::updateAutoMarginsInRowAxisIfNeeded):
(WebCore::RenderGrid::updateAutoMarginsInColumnAxisIfNeeded):

Canonical link: https://commits.webkit.org/288355@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications