[webkit-changes] [WebKit/WebKit] 23e166: Fix a compile warning in ElementTextPreview.mm wit...

Ryosuke Niwa noreply at github.com
Fri Feb 28 23:21:10 PST 2025


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 23e166fc9183092b4046f160225aba1e07f38fe4
      https://github.com/WebKit/WebKit/commit/23e166fc9183092b4046f160225aba1e07f38fe4
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2025-02-28 (Fri, 28 Feb 2025)

  Changed paths:
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/ElementTextPreview.mm

  Log Message:
  -----------
  Fix a compile warning in ElementTextPreview.mm with stable/202407232 branch of clang
https://bugs.webkit.org/show_bug.cgi?id=288904

Reviewed by Abrar Rahman Protyasha.

Fix the following warning generated for the line 54 of ElementTextPreview.mm
with stable/202407232 branch of clang.

gtest.h:1379:11: error: comparison of distinct pointer types ('id<NSCollectionLayoutContainer>' and 'TestWKWebView *') [-Werror,-Wcompare-distinct-pointer-types]
 1379 |   if (lhs == rhs) {
      |       ~~~ ^  ~~~

* Tools/TestWebKitAPI/Tests/WebKitCocoa/ElementTextPreview.mm:
(TestWebKitAPI::TEST(ElementTextPreview, PreviewForElement)):

Canonical link: https://commits.webkit.org/291431@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list