[webkit-changes] [WebKit/WebKit] 88b4be: Support alignment properties (align-self/justify-s...

[fantasai]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 88b4bea020234d7fd33e88acbb82d580a46130c0
      https://github.com/WebKit/WebKit/commit/88b4bea020234d7fd33e88acbb82d580a46130c0
  Author: Elika Etemad <fantasai.bugs at inkedblade.net>
  Date:   2025-02-28 (Fri, 28 Feb 2025)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/align-self-htb-ltr-htb-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/align-self-htb-ltr-vlr-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/align-self-htb-ltr-vrl-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/align-self-htb-rtl-htb-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/align-self-htb-rtl-vlr-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/align-self-htb-rtl-vrl-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/align-self-vlr-ltr-htb-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/align-self-vlr-ltr-vlr-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/align-self-vlr-ltr-vrl-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/align-self-vlr-rtl-htb-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/align-self-vlr-rtl-vlr-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/align-self-vlr-rtl-vrl-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/align-self-vrl-ltr-htb-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/align-self-vrl-ltr-vlr-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/align-self-vrl-ltr-vrl-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/align-self-vrl-rtl-htb-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/align-self-vrl-rtl-vlr-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/align-self-vrl-rtl-vrl-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/justify-self-htb-ltr-htb-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/justify-self-htb-ltr-vlr-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/justify-self-htb-ltr-vrl-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/justify-self-htb-rtl-htb-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/justify-self-htb-rtl-vlr-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/justify-self-htb-rtl-vrl-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/justify-self-vlr-ltr-htb-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/justify-self-vlr-ltr-vlr-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/justify-self-vlr-ltr-vrl-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/justify-self-vlr-rtl-htb-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/justify-self-vlr-rtl-vlr-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/justify-self-vlr-rtl-vrl-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/justify-self-vrl-ltr-htb-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/justify-self-vrl-ltr-vlr-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/justify-self-vrl-ltr-vrl-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/justify-self-vrl-rtl-htb-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/justify-self-vrl-rtl-vlr-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/justify-self-vrl-rtl-vrl-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/safe-align-self-htb-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/safe-align-self-vlr-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/safe-align-self-vrl-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/safe-justify-self-htb-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/safe-justify-self-vlr-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/safe-justify-self-vrl-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/stretch-intrinsic-size-htb-htb-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/stretch-intrinsic-size-htb-vrl-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/stretch-intrinsic-size-vrl-htb-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/stretch-intrinsic-size-vrl-vrl-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-try-order-basic-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/try-tactic-alignment-expected.txt
    M Source/WebCore/rendering/RenderBox.cpp
    M Source/WebCore/rendering/style/StyleSelfAlignmentData.cpp
    M Source/WebCore/rendering/style/StyleSelfAlignmentData.h

  Log Message:
  -----------
  Support alignment properties (align-self/justify-self) in absolute positioned layout
https://bugs.webkit.org/show_bug.cgi?id=288531
rdar://145689547

Reviewed by Alan Baradlay.

Add basic support for align-self/justify-self in absolutely positioned layout.
Also fix some orthogonal flow coordinate stuff covered by those tests.

* LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/align-self-htb-ltr-htb-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/align-self-htb-ltr-vlr-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/align-self-htb-ltr-vrl-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/align-self-htb-rtl-htb-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/align-self-htb-rtl-vlr-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/align-self-htb-rtl-vrl-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/align-self-vlr-ltr-htb-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/align-self-vlr-ltr-vlr-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/align-self-vlr-ltr-vrl-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/align-self-vlr-rtl-htb-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/align-self-vlr-rtl-vlr-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/align-self-vlr-rtl-vrl-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/align-self-vrl-ltr-htb-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/align-self-vrl-ltr-vlr-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/align-self-vrl-ltr-vrl-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/align-self-vrl-rtl-htb-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/align-self-vrl-rtl-vlr-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/align-self-vrl-rtl-vrl-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/justify-self-htb-ltr-htb-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/justify-self-htb-ltr-vlr-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/justify-self-htb-ltr-vrl-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/justify-self-htb-rtl-htb-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/justify-self-htb-rtl-vlr-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/justify-self-htb-rtl-vrl-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/justify-self-vlr-ltr-htb-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/justify-self-vlr-ltr-vlr-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/justify-self-vlr-ltr-vrl-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/justify-self-vlr-rtl-htb-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/justify-self-vlr-rtl-vlr-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/justify-self-vlr-rtl-vrl-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/justify-self-vrl-ltr-htb-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/justify-self-vrl-ltr-vlr-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/justify-self-vrl-ltr-vrl-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/justify-self-vrl-rtl-htb-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/justify-self-vrl-rtl-vlr-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/justify-self-vrl-rtl-vrl-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/safe-align-self-htb-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/safe-align-self-vlr-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/safe-align-self-vrl-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/safe-justify-self-htb-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/safe-justify-self-vlr-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/safe-justify-self-vrl-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/stretch-intrinsic-size-htb-htb-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/stretch-intrinsic-size-htb-vrl-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/stretch-intrinsic-size-vrl-htb-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-align/abspos/stretch-intrinsic-size-vrl-vrl-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/position-try-order-basic-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/try-tactic-alignment-expected.txt:
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::PositionedLayoutConstraints::containingCoordsAreFlipped const):
(WebCore::RenderBox::PositionedLayoutConstraints::captureInsets):
(WebCore::RenderBox::PositionedLayoutConstraints::resolvePosition const):
(WebCore::RenderBox::PositionedLayoutConstraints::resolveAlignmentAdjustment const):
(WebCore::RenderBox::computePositionedLogicalWidth const):
(WebCore::RenderBox::PositionedLayoutConstraints::convertLogicalLeftValue const):
(WebCore::RenderBox::computePositionedLogicalWidthUsing const):
(WebCore::RenderBox::computePositionedLogicalHeightUsing const):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced const):
(WebCore::RenderBox::computeAnchorCenteredPosition const):
* Source/WebCore/rendering/style/StyleSelfAlignmentData.cpp:
(WebCore::StyleSelfAlignmentData::adjustmentFromStartEdge):
* Source/WebCore/rendering/style/StyleSelfAlignmentData.h:

Canonical link: https://commits.webkit.org/291417@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications