[webkit-changes] [WebKit/WebKit] 12e2a1: [text-wrap-style:pretty] track index of last valid...

[Yulun Wu]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 12e2a141d2c28e2c77da13d718d110ca447ab12e
      https://github.com/WebKit/WebKit/commit/12e2a141d2c28e2c77da13d718d110ca447ab12e
  Author: Yulun Wu <yulunwu at chromium.org>
  Date:   2025-02-28 (Fri, 28 Feb 2025)

  Changed paths:
    A LayoutTests/fast/css3-text/css3-text-wrap/text-wrap-pretty-line-break-crash-2-expected.txt
    A LayoutTests/fast/css3-text/css3-text-wrap/text-wrap-pretty-line-break-crash-2.html
    A LayoutTests/fast/css3-text/css3-text-wrap/text-wrap-pretty-line-break-crash-expected.txt
    A LayoutTests/fast/css3-text/css3-text-wrap/text-wrap-pretty-line-break-crash.html
    M Source/WebCore/layout/formattingContexts/inline/InlineContentConstrainer.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineContentConstrainer.h

  Log Message:
  -----------
  [text-wrap-style:pretty] track index of last valid state instead of breakpoint.
https://bugs.webkit.org/show_bug.cgi?id=288615
<rdar://145669941>

Reviewed by Alan Baradlay.

InlineContentConstrainer::prettifyRange() should track the lastValidStateindex
instead of the lastValidBreakpoint. We were writting the EntryPretty from
layoutSingleLineForPretty() to the incorrect place in state[]. This was causing
an index out of bounds exception in the attached test case.

Canonical link: https://commits.webkit.org/291401@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications